--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 4F7CE431FB6\r
+ for <notmuch@notmuchmail.org>; Wed, 5 Dec 2012 07:59:12 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id u9b540Wn1WBX for <notmuch@notmuchmail.org>;\r
+ Wed, 5 Dec 2012 07:59:08 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU\r
+ [18.9.25.12])\r
+ by olra.theworths.org (Postfix) with ESMTP id 2F6CA431FAE\r
+ for <notmuch@notmuchmail.org>; Wed, 5 Dec 2012 07:59:08 -0800 (PST)\r
+X-AuditID: 1209190c-b7f886d000000936-37-50bf6f4bff2a\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+ by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 11.80.02358.B4F6FB05; Wed, 5 Dec 2012 10:59:07 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id qB5Fx6lA005707; \r
+ Wed, 5 Dec 2012 10:59:07 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qB5Fx4AD003807\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Wed, 5 Dec 2012 10:59:06 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1TgHNI-0007ss-G6; Wed, 05 Dec 2012 10:59:04 -0500\r
+From: Austin Clements <aclements@csail.mit.edu>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: show: refresh buffer did not remove overlays\r
+In-Reply-To: <1354709509-22123-1-git-send-email-markwalters1009@gmail.com>\r
+References: <20121203164730.GE1020@mit.edu>\r
+ <1354709509-22123-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.14+100~gcb9b0b0 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Wed, 05 Dec 2012 10:59:04 -0500\r
+Message-ID: <87mwxscwxj.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsUixCmqrOudvz/A4OxZFYvVc3ksrt+cyezA\r
+ 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZTzeZF1wkKfi/dppzA2Mfzi7GDk5JARMJBZ1\r
+ vGSCsMUkLtxbz9bFyMUhJLCPUeJoYzsrhLOeUWL+sxZmCOcCk8TVma+YIJwljBJ/nvxlBOln\r
+ E9CXWLF2EiuILSLgKvH022dmEFtYwFvizo77QDUcHJwCXhJNPdwgppBApsTmGREgpqhAvMTl\r
+ pQogxSwCqhIf7t8CG8ILdNz2pctYIGxBiZMzn4DZzAJaEjf+vWSawCgwC0lqFpLUAkamVYyy\r
+ KblVurmJmTnFqcm6xcmJeXmpRbqGermZJXqpKaWbGMGhKMmzg/HNQaVDjAIcjEo8vJLG+wKE\r
+ WBPLiitzDzFKcjApifL+zN0fIMSXlJ9SmZFYnBFfVJqTWnyIUYKDWUmEt9gPKMebklhZlVqU\r
+ D5OS5mBREue9nHLTX0ggPbEkNTs1tSC1CCYrw8GhJMFbkQfUKFiUmp5akZaZU4KQZuLgBBnO\r
+ AzQ8DqSGt7ggMbc4Mx0if4pRUUqcdwJIQgAkkVGaB9cLSxWvGMWBXhHmnQhSxQNMM3Ddr4AG\r
+ MwENjmIHG1ySiJCSamAMaLje6+FS2zVRwqjp9DWp1+5Tk9/cDLjPf3DRnflywlO1z1YtEY1T\r
+ vW9bMO/EzXUdZ5W9jNlcbnnzf/+7U7l2kVL0F5ny7JlSl2f2cGW/1GWr+O5rtfjVu8mdk902\r
+ enUJtL9m5RUx4VknZjrlmF/WtL60qW3PbR9+j7Dbr7mxoDrCRTi1yVOJpTgj0VCLuag4EQD+\r
+ XroU8AIAAA==\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 05 Dec 2012 15:59:12 -0000\r
+\r
+LGTM.\r
+\r
+On Wed, 05 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> Previously refreshing the notmuch show buffer did not remove overlays\r
+> which meant that if the user refreshed a message with images the\r
+> images would remain and then the new text was added after.\r
+>\r
+> One might have guessed that erase-buffer would have removed them but\r
+> it seems not. Thus force the removal of overlays with remove-overlays.\r
+> ---\r
+>\r
+> This version fixes the problems that Austin mentioned in his review. I\r
+> have not investigated whether the erase-buffer here can be removed: it\r
+> looks like it could be but the worst that this does is call\r
+> erase-buffer twice (slightly wasteful but no harm).\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+> emacs/notmuch-show.el | 4 ++++\r
+> 1 files changed, 4 insertions(+), 0 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 4d6c014..20f8997 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1185,6 +1185,10 @@ reset based on the original query."\r
+> (let ((inhibit-read-only t)\r
+> (state (unless reset-state\r
+> (notmuch-show-capture-state))))\r
+> + ;; erase-buffer does not seem to remove overlays, which can lead\r
+> + ;; to weird effects such as remaining images, so remove them\r
+> + ;; manually.\r
+> + (remove-overlays)\r
+> (erase-buffer)\r
+> (notmuch-show-build-buffer)\r
+> (if state\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff