Add a note about potential for config mixups in elog finalizers.
authorZac Medico <zmedico@gentoo.org>
Fri, 22 Jun 2007 12:57:41 +0000 (12:57 -0000)
committerZac Medico <zmedico@gentoo.org>
Fri, 22 Jun 2007 12:57:41 +0000 (12:57 -0000)
svn path=/main/trunk/; revision=6952

pym/portage/elog/__init__.py

index 5b8ac44c3aa92da2d67d810af8a8383d4641d47e..1cf4dd8b8c3628daa25109d85090fadff628f9f9 100644 (file)
@@ -95,6 +95,11 @@ def elog_process(cpv, mysettings):
                                        m.process(mysettings, str(key), mod_logentries, mod_fulllog)
                                finally:
                                        signal.alarm(0)
+                               # FIXME: when installing to more than one $ROOT, the finalizer
+                               # will only be registered with a config instance from one of
+                               # the roots (randomly).  With PORTAGE_CONFIGROOT, the config
+                               # instances can have completely different settings, so
+                               # logs can end up in the wrong PORT_LOGDIR for example.
                                if hasattr(m, "finalize") and not m.finalize in _elog_atexit_handlers:
                                        _elog_atexit_handlers.append(m.finalize)
                                        atexit_register(m.finalize, mysettings)