--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 2A955429E21\r
+ for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 14:44:12 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.401\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.401 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id hmrjTVJ+H8Zo for <notmuch@notmuchmail.org>;\r
+ Tue, 22 Oct 2013 14:44:06 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 012A6431FDE\r
+ for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 14:44:05 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1VYjk3-0006l5-4a; Tue, 22 Oct 2013 22:43:57 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1VYjk2-0005zE-Pa; Tue, 22 Oct 2013 22:43:54 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/8] Improve tag change completion\r
+In-Reply-To: <1382471457-26056-1-git-send-email-amdragon@mit.edu>\r
+References: <1382471457-26056-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 22 Oct 2013 22:43:53 +0100\r
+Message-ID: <87mwm1x9pi.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: e0c77d7dadca19c97f6dc04e6a0b8e19 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.6\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.6 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 1.0 FREEMAIL_REPLY From and body contain different freemails\r
+ * -0.4 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 22 Oct 2013 21:44:12 -0000\r
+\r
+\r
+This looks good to me +1. It makes the code clearer and nicer to read as\r
+well as giving a better user experience, and it is makes fixing the long\r
+standing tagging races simpler.\r
+\r
+I have a couple of docstring comments:\r
+\r
+In patch 2 perhaps notmuch-tag-completions could have a docstring.\r
+\r
+In Patch 4 I think the docstring for notmuch-search-tag is outdated: it\r
+ is "Change tags for the currently selected thread or region." but \r
+ beg and end can now be specified by the caller.\r
+\r
+and one actual comment:\r
+\r
+in patch 3 (for show) delete-dups is called before the list is passed to\r
+notmuch-read-tag-changes whereas it is not for search or pick.\r
+Obviously this is not actually a problem but it might be worth being\r
+consistent.\r
+\r
+But that was all I found. All tests pass and everything I try behaves\r
+exactly as expected.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+On Tue, 22 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> This series improves tag change completion in various ways for\r
+> commands like +, -, and *.\r
+>\r
+> From a user perspective, this provides command-specific prompts like\r
+> "Tag message" and "Tag all" instead of the generic "Tag" prompt, and\r
+> bases tag removal completions on the tags that are in the buffer,\r
+> rather than the current tags in the database, providing a more\r
+> predicable experience.\r
+>\r
+> From an implementation perspective, this new tag removal completion\r
+> behavior improves efficiency and eliminates a road block to fixing the\r
+> tagging race bug (which otherwise results in massive queries just to\r
+> compute removal completions). The new code is also more "Elispy" and\r
+> predictable because all tag change prompting now occurs at the\r
+> interactive entry points, rather than buried under several layers of\r
+> non-interactive calls.\r
+>\r
+> This is a spiritual successor to\r
+> id:1354263691-19715-1-git-send-email-markwalters1009@gmail.com, though\r
+> it takes a very different approach. This is also a prerequisite to\r
+> the tag race fix in\r
+> id:1381185201-25197-1-git-send-email-amdragon@mit.edu and I plan to\r
+> send an updated version of that series when this one is accepted.\r
+>\r
+> Patches 1, 5, and 6 could be pushed on their own. They fix bugs or\r
+> sort of bugs that get in the way of the rest of the series.\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff