Don't bail out if postinst fails. Thanks to Brain Harring for the suggestion.
authorZac Medico <zmedico@gentoo.org>
Mon, 18 Jan 2010 22:53:24 +0000 (22:53 -0000)
committerZac Medico <zmedico@gentoo.org>
Mon, 18 Jan 2010 22:53:24 +0000 (22:53 -0000)
svn path=/main/trunk/; revision=15202

pym/portage/dbapi/vartree.py

index 07286b6027f21014379ecb7b537882c4b9b55094..46b7f8333154c66d0216b3e263be8ff189a04b92 100644 (file)
@@ -3992,11 +3992,11 @@ class dblink(object):
                finally:
                        self.settings.pop("PORTAGE_UPDATE_ENV", None)
 
-               # XXX: Decide how to handle failures here.
                if a != os.EX_OK:
+                       # It's stupid to bail out here, so keep going regardless of
+                       # phase return code.
                        showMessage(_("!!! FAILED postinst: ")+str(a)+"\n",
                                level=logging.ERROR, noiselevel=-1)
-                       return a
 
                downgrade = False
                for v in otherversions: