Re: [Patch v2 09/13] CLI: add optional config data to dump output.

diff --git a/9a/bc459fb25b1411cfdb66c4a7b293a9032b2c67 b/9a/bc459fb25b1411cfdb66c4a7b293a9032b2c67
new file mode 100644 (file)
index 0000000..36b1502
--- /dev/null
+++ b/9a/bc459fb25b1411cfdb66c4a7b293a9032b2c67
@@ -0,0 +1,69 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 6E0896DE026C\r
+ for <notmuch@notmuchmail.org>; Sat, 26 Mar 2016 11:13:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.026\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.026 tagged_above=-999 required=5\r
+ tests=[AWL=-0.015, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id sEaihRchzxvc for <notmuch@notmuchmail.org>;\r
+ Sat, 26 Mar 2016 11:13:51 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 321D86DE00F1\r
+ for <notmuch@notmuchmail.org>; Sat, 26 Mar 2016 11:13:50 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1ajsjB-000196-JV; Sat, 26 Mar 2016 14:14:25 -0400\r
+Received: (nullmailer pid 25618 invoked by uid 1000);\r
+ Sat, 26 Mar 2016 18:13:47 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [Patch v2 09/13] CLI: add optional config data to dump output.\r
+In-Reply-To: <1459015043-8460-10-git-send-email-david@tethera.net>\r
+References: <1459015043-8460-1-git-send-email-david@tethera.net>\r
+ <1459015043-8460-10-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.21+5~gca076ce (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 26 Mar 2016 15:13:47 -0300\r
+Message-ID: <87y495ksys.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 26 Mar 2016 18:13:59 -0000\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> Note that it changes the default dump output format, but doesn't break\r
+> existing notmuch-restore. It might break user scripts though.\r
+\r
+blush. One of the things it breaks is nmbug. The quick and dirty fix\r
+would be to have nmbug ignore any comment lines in the dump output.\r
+\r
+There is an option to the new dump (--include=tags) which omits the\r
+config information, but it still adds a single header line. I'd be open\r
+to the idea of omitting the header line if there is no config\r
+information in the file.\r
+\r
+The other question is if the current default of including configuration\r
+information is a good idea. For the most obvious use case of backing up the\r
+user's data, it seems like the right thing to do.\r
+\r
+d\r