--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 531B6429E31\r
+ for <notmuch@notmuchmail.org>; Fri, 31 May 2013 17:40:28 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id DQC6wUIk8pOe for <notmuch@notmuchmail.org>;\r
+ Fri, 31 May 2013 17:40:22 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-1.mit.edu (dmz-mailsec-scanner-1.mit.edu\r
+ [18.9.25.12])\r
+ by olra.theworths.org (Postfix) with ESMTP id D7A2E431E82\r
+ for <notmuch@notmuchmail.org>; Fri, 31 May 2013 17:40:16 -0700 (PDT)\r
+X-AuditID: 1209190c-b7f566d000004c69-48-51a942f06008\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+ by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 85.73.19561.0F249A15; Fri, 31 May 2013 20:40:16 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+ by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id r510eDsq024662; \r
+ Fri, 31 May 2013 20:40:14 -0400\r
+Received: from drake.dyndns.org (c-76-21-105-205.hsd1.ca.comcast.net\r
+ [76.21.105.205]) (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r510eAvc020947\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Fri, 31 May 2013 20:40:12 -0400\r
+Received: from amthrax by drake.dyndns.org with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1UiZrd-0003QY-Li; Fri, 31 May 2013 20:40:09 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v3 5/6] emacs: Use streaming S-expr parser for search\r
+Date: Fri, 31 May 2013 20:40:07 -0400\r
+Message-Id: <1370047208-12785-6-git-send-email-amdragon@mit.edu>\r
+X-Mailer: git-send-email 1.7.10.4\r
+In-Reply-To: <1370047208-12785-1-git-send-email-amdragon@mit.edu>\r
+References: <1370047208-12785-1-git-send-email-amdragon@mit.edu>\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsUixG6novvBaWWgwYoWVYvVc3ksrt+cyWzx\r
+ ZuU8Vgdmj52z7rJ7HP66kMXj2apbzAHMUVw2Kak5mWWpRfp2CVwZz+cqFVyXr3h/+CpjA+Nb\r
+ yS5GTg4JAROJN2+7mSBsMYkL99azdTFycQgJ7GOU+PS7iw0kISSwkVFi1w1OiMRpJon9Dzez\r
+ QyTmMkpMXckIYrMJaEhs278czBYRkJbYeXc2K4jNLBAnsWXKf7C4sICrROvOjcwgNouAqsTM\r
+ 6efA5vAKOEhcWNLJDnGFokT3swlgizkFHCXOX/3HDLHLQeLxiZPMExj5FzAyrGKUTcmt0s1N\r
+ zMwpTk3WLU5OzMtLLdI11MvNLNFLTSndxAgKLE5Jnh2Mbw4qHWIU4GBU4uHtWLUiUIg1say4\r
+ MvcQoyQHk5Io72zHlYFCfEn5KZUZicUZ8UWlOanFhxglOJiVRHjz5wCV86YkVlalFuXDpKQ5\r
+ WJTEeS+n3PQXEkhPLEnNTk0tSC2CycpwcChJ8L4EGSpYlJqeWpGWmVOCkGbi4AQZzgM0/BxI\r
+ DW9xQWJucWY6RP4Uo6KUOO8FkIQASCKjNA+uFxb5rxjFgV4R5uUGpgEhHmDSgOt+BTSYCWjw\r
+ E+vlIINLEhFSUg2M+bm631M11HsaZWQelQa4Hwy7PMlDc6Pa2oq4xwqmJ2WmsP4yLo8SNEle\r
+ dOz5IZMPxndSrwnMceD7y1BmuqAzfeayrxvDH891ypk+Z53CpWqnybevRexO4au/XuC4IX3b\r
+ BrXLET/5l0yJWb5I6HxK4Ra2Hg0D7b8NZxdZrXZznTVf+/GDuj4rJZbijERDLeai4kQAuVt/\r
+ cNcCAAA=\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 01 Jun 2013 00:40:28 -0000\r
+\r
+In addition to being the Right Thing to do, this noticeably improves\r
+the time taken to display the first page of search results, since it's\r
+roughly an order of magnitude faster than the JSON parser.\r
+Interestingly, it does *not* significantly improve the time to\r
+completely fill a large search buffer because for large search\r
+buffers, the cost of creating author invisibility overlays and\r
+inserting text (which slows down with more overlays) dominates.\r
+However, the time required to display the first page of results is\r
+generally more important to the user experience.\r
+---\r
+ emacs/notmuch.el | 13 +++----------\r
+ test/emacs | 10 +++-------\r
+ 2 files changed, 6 insertions(+), 17 deletions(-)\r
+\r
+diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+index b8d9c44..5a8c957 100644\r
+--- a/emacs/notmuch.el\r
++++ b/emacs/notmuch.el\r
+@@ -58,6 +58,7 @@\r
+ (require 'notmuch-hello)\r
+ (require 'notmuch-maildir-fcc)\r
+ (require 'notmuch-message)\r
++(require 'notmuch-parser)\r
+ \r
+ (defcustom notmuch-search-result-format\r
+ `(("date" . "%12s ")\r
+@@ -809,13 +810,6 @@ non-authors is found, assume that all of the authors match."\r
+ (setq notmuch-search-target-thread "found")\r
+ (goto-char beg)))))\r
+ \r
+-(defun notmuch-search-show-error (string &rest objects)\r
+- (save-excursion\r
+- (goto-char (point-max))\r
+- (insert "Error: Unexpected output from notmuch search:\n")\r
+- (insert (apply #'format string objects))\r
+- (insert "\n")))\r
+-\r
+ (defun notmuch-search-process-filter (proc string)\r
+ "Process and filter the output of \"notmuch search\""\r
+ (let ((results-buf (process-buffer proc))\r
+@@ -829,8 +823,7 @@ non-authors is found, assume that all of the authors match."\r
+ (save-excursion\r
+ (goto-char (point-max))\r
+ (insert string))\r
+- (notmuch-json-parse-partial-list 'notmuch-search-show-result\r
+- 'notmuch-search-show-error\r
++ (notmuch-sexp-parse-partial-list 'notmuch-search-show-result\r
+ results-buf)))))\r
+ \r
+ (defun notmuch-search-tag-all (&optional tag-changes)\r
+@@ -933,7 +926,7 @@ Other optional parameters are used as follows:\r
+ (save-excursion\r
+ (let ((proc (notmuch-start-notmuch\r
+ "notmuch-search" buffer #'notmuch-search-process-sentinel\r
+- "search" "--format=json" "--format-version=1"\r
++ "search" "--format=sexp" "--format-version=1"\r
+ (if oldest-first\r
+ "--sort=oldest-first"\r
+ "--sort=newest-first")\r
+diff --git a/test/emacs b/test/emacs\r
+index d38ae8c..7d42abf 100755\r
+--- a/test/emacs\r
++++ b/test/emacs\r
+@@ -856,7 +856,7 @@ test_expect_success "Rendering HTML mail with images" \\r
+ test_begin_subtest "Search handles subprocess error exit codes"\r
+ cat > notmuch_fail <<EOF\r
+ #!/bin/sh\r
+-echo This is output\r
++echo '()'\r
+ exit 1\r
+ EOF\r
+ chmod a+x notmuch_fail\r
+@@ -871,21 +871,19 @@ test_emacs "(let ((notmuch-command \"$PWD/notmuch_fail\"))\r
+ (test-output))"\r
+ sed -i -e 's/^\[.*\]$/[XXX]/' ERROR\r
+ test_expect_equal "$(cat OUTPUT; echo ---; cat MESSAGES; echo ---; cat ERROR)" "\\r
+-Error: Unexpected output from notmuch search:\r
+-This is output\r
+ End of search results.\r
+ ---\r
+ $PWD/notmuch_fail exited with status 1 (see *Notmuch errors* for more details)\r
+ ---\r
+ [XXX]\r
+ $PWD/notmuch_fail exited with status 1\r
+-command: $PWD/notmuch_fail search --format\=json --format-version\=1 --sort\=newest-first tag\:inbox\r
++command: $PWD/notmuch_fail search --format\=sexp --format-version\=1 --sort\=newest-first tag\:inbox\r
+ exit status: 1"\r
+ \r
+ test_begin_subtest "Search handles subprocess warnings"\r
+ cat > notmuch_fail <<EOF\r
+ #!/bin/sh\r
+-echo This is output\r
++echo '()'\r
+ echo This is a warning >&2\r
+ echo This is another warning >&2\r
+ exit 0\r
+@@ -903,8 +901,6 @@ test_emacs "(let ((notmuch-command \"$PWD/notmuch_fail\"))\r
+ (test-output))"\r
+ sed -i -e 's/^\[.*\]$/[XXX]/' ERROR\r
+ test_expect_equal "$(cat OUTPUT; echo ---; cat MESSAGES; echo ---; cat ERROR)" "\\r
+-Error: Unexpected output from notmuch search:\r
+-This is output\r
+ End of search results.\r
+ ---\r
+ This is a warning (see *Notmuch errors* for more details)\r
+-- \r
+1.7.10.4\r
+\r
projects / notmuch-archives.git / commitdiff