Re: [PATCH 4/4] database: Handle error while deleting uncompacted database

diff --git a/b3/cee76b1765946e4a2e5edb6bbc1706c9693bf3 b/b3/cee76b1765946e4a2e5edb6bbc1706c9693bf3
new file mode 100644 (file)
index 0000000..52548e7
--- /dev/null
+++ b/b3/cee76b1765946e4a2e5edb6bbc1706c9693bf3
@@ -0,0 +1,107 @@
+Return-Path: <bgamari.foss@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 109FB429E4D\r
+       for <notmuch@notmuchmail.org>; Mon,  4 Nov 2013 12:06:20 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id d7fmVzvwhJvQ for <notmuch@notmuchmail.org>;\r
+       Mon,  4 Nov 2013 12:06:12 -0800 (PST)\r
+Received: from mail-qc0-f179.google.com (mail-qc0-f179.google.com\r
+       [209.85.216.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 0CF57429E36\r
+       for <notmuch@notmuchmail.org>; Mon,  4 Nov 2013 12:06:11 -0800 (PST)\r
+Received: by mail-qc0-f179.google.com with SMTP id k18so4248012qcv.38\r
+       for <notmuch@notmuchmail.org>; Mon, 04 Nov 2013 12:06:11 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=VrR/+xHPTHqBwJoBVmWNHqeHh6WsHNGkaUpPo0asZ14=;\r
+       b=XaY6+cd5f+qGJSDgAU+rgjOhJcPaUxMqumKf8W6yImvcF/YOe5gPHMArZl9Wk4jW+p\r
+       +R6Ivj1ApNTrHlWXT40YV6ILiIi4GFGYV1U+IAWwMGZePcM8mvHJh7rAcPq/B0FI5+8v\r
+       icILGvZBbHmgnv8z2eCP/MImSFgi5OxdYl3vZcccmcGEEFVg1Q5Nd6T97trARa3DHJbG\r
+       +AH8kepP1yi2tCZCFE8mq9vjM0VoNfJ4Ehg7+ukX0CZ+y99X/zGnK/IQeXR94e0IxVaj\r
+       04GONIQNLRBM8s7etKk5V270lIOZEaCfK4nNHPs+Fh6ZEhYOKbtGsbDhQ14CpG6rxvMT\r
+       pvDA==\r
+X-Received: by 10.49.30.66 with SMTP id q2mr24593477qeh.38.1383595570458;\r
+       Mon, 04 Nov 2013 12:06:10 -0800 (PST)\r
+Received: from localhost (gamari.physics.umass.edu. [128.119.56.223])\r
+       by mx.google.com with ESMTPSA id jw9sm50857040qeb.2.2013.11.04.12.06.09\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Mon, 04 Nov 2013 12:06:09 -0800 (PST)\r
+From: Ben Gamari <bgamari.foss@gmail.com>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 4/4] database: Handle error while deleting uncompacted\r
+       database\r
+In-Reply-To: <87fvrfrnzy.fsf@zancas.localnet>\r
+References: <1382998997-9938-1-git-send-email-bgamari.foss@gmail.com>\r
+       <1382998997-9938-4-git-send-email-bgamari.foss@gmail.com>\r
+       <87fvrfrnzy.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.16+107~g1ef2773 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 04 Nov 2013 15:06:07 -0500\r
+Message-ID: <87zjpknd8w.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 04 Nov 2013 20:06:20 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> Ben Gamari <bgamari.foss@gmail.com> writes:\r
+>\r
+>> We never checked to ensure that the rmtree() of the old database\r
+>> succeeded.\r
+>>\r
+>\r
+> Is there some reason these patches (and the existing compact code in the\r
+> lib) is using fprintf and not the status callback function? Most places\r
+> we don't (yet) have logging callbacks, but here we do.\r
+>\r
+Nope. I simply wasn't aware of this infrastructure. I can put together a\r
+patch to fix this.\r
+\r
+Cheers,\r
+\r
+- Ben\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.14 (GNU/Linux)\r
+\r
+iQEcBAEBAgAGBQJSd/4vAAoJEErkyLZmeNiDDgoH/i78hudgxfKzBvru6O7UYots\r
+PbEyHg89Fa3KZbmNWVVlcdS3+ZOA/IMKgJ9JI8j0Qdt0GphLTmRP9PidWLRod9UX\r
+7CqQ70wxrl7BHkyY3xHjt8WjZR/Upb7iFQzeobwpLoc53v3vq7rj2WznEbRxi6AW\r
+ZYpLjxrMMKrq0/tKkM22bzv5SO0r+5YPngDpd3y42kvSCZUlbD86USY7cynH1jAN\r
+xSRh65g4mMKW1sg9naMpETUogV4vw3Kk56qTMkoi6Kt/LcaiuI5u4n4AOI6LfyIQ\r
+lPOOjFy2/rSHqbGVZ7lAkoCikYzfMLK1aM47CmizanJlkguytlKoSQiHFxrgHJo=\r
+=0Gql\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r