--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id DB51C431FAF\r
+ for <notmuch@notmuchmail.org>; Mon, 27 May 2013 15:30:50 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id KR0pil+fFfTq for <notmuch@notmuchmail.org>;\r
+ Mon, 27 May 2013 15:30:45 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id A35B1431FAE\r
+ for <notmuch@notmuchmail.org>; Mon, 27 May 2013 15:30:45 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Uh5w7-0005Mc-5b; Mon, 27 May 2013 23:30:44 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Uh5w6-0000DD-Si; Mon, 27 May 2013 23:30:39 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/4] emacs: Part command improvements\r
+In-Reply-To: <1369687594-31774-1-git-send-email-amdragon@mit.edu>\r
+References: <1369687594-31774-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Mon, 27 May 2013 23:30:37 +0100\r
+Message-ID: <87zjvghx82.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 45b9b14c3ff81e8ea343cc6b3369bac8 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -0.1 points.\r
+ Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 27 May 2013 22:30:51 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> This is a follow-up of sorts to id:"8761ycc19t.fsf@qmul.ac.uk", where\r
+> Mark suggested that the part handling commands could all use the\r
+> correponding mm-* functions. I ran with the idea and wound up with\r
+> this series, which, in addition to standardizing on the mm-* functions\r
+> for everything and simplifying the implementation overall, decouples\r
+> the part commands from part buttons, which removes an entire layer\r
+> from the implementation and adds the ability to invoke part commands\r
+> with point anywhere in a part (something I often find myself wanting).\r
+\r
+Overall I really like this series. In addition to the clean up etc it\r
+makes it easy to export the text/plain part (which doesn't have a part\r
+button). I have recollection of this being difficult if it is base64\r
+encoded.\r
+\r
+I have a few small comments\r
+\r
+As mentioned on irc (just included here in case other people are\r
+testing) make-composed-keymap is emacs 24 only.\r
+\r
+This does change the default directory for saving: not serious but it's\r
+probably worth deciding do we want to use mailcap-download-directory or\r
+home or where emacs was started or?\r
+\r
+I don't know if we want to keep a special keymap for the button or just\r
+always use the . prefix; the advantage is that you don't have 's' on a\r
+button acting differently from 's' in the text (which has annoyed me\r
+several times) otoh it is the extra keystroke which may annoy people\r
+too. Let the bikeshedding begin! (obviously return for the default\r
+action would remain.\r
+\r
+Would it be worth having . return in the part body as the default\r
+action ?\r
+\r
+Finally, with message indenting it's the start/end of the part are a\r
+little unclear. I think it's the [ of the part button at the start of\r
+the part to the character before the [ of the next part button. In\r
+particular on the line of a new part but before the button is still the\r
+old part. Since parts are whole lines it would be nice if the region\r
+were line based but I don't know if that is easy.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
projects / notmuch-archives.git / commitdiff