--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0F83E431FB6\r
+ for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 13:18:13 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id lpKb6JWMZJB3 for <notmuch@notmuchmail.org>;\r
+ Fri, 24 Jan 2014 13:18:04 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-5.mit.edu (dmz-mailsec-scanner-5.mit.edu\r
+ [18.7.68.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id 2A2E1431FC0\r
+ for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 13:18:04 -0800 (PST)\r
+X-AuditID: 12074422-f79526d000000c47-ed-52e2d88b1ddf\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+ (using TLS with cipher AES256-SHA (256/256 bits))\r
+ (Client did not present a certificate)\r
+ by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 99.0F.03143.B88D2E25; Fri, 24 Jan 2014 16:18:03 -0500 (EST)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+ by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id s0OLI2eT026233; \r
+ Fri, 24 Jan 2014 16:18:03 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s0OLHx5F020179\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Fri, 24 Jan 2014 16:18:01 -0500\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1W6o8V-0006Dc-9F; Fri, 24 Jan 2014 16:17:59 -0500\r
+From: Austin Clements <aclements@csail.mit.edu>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/5] lib: make folder: prefix literal\r
+In-Reply-To: <cover.1389304779.git.jani@nikula.org>\r
+References: <cover.1389304779.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.17~rc2+14~g06f47e0 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Fri, 24 Jan 2014 16:17:58 -0500\r
+Message-ID: <87y525m649.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsUixCmqrdt941GQwbz9yhZN050trt+cyezA\r
+ 5HHr/mt2j2erbjEHMEVx2aSk5mSWpRbp2yVwZbT17mEuuCxZMXmCSwPjMeEuRk4OCQETif4n\r
+ D1ghbDGJC/fWs3UxcnEICcxmkjj7awMLhLORUaJt3i1GCOc0k8Sk+bOhMksYJXafbAXrZxPQ\r
+ l1ixdhKYLSJgJXHu4WsWEFtYwFJi6p0pTCA2p4CxxJ7dixhBbCEBI4nTd9rZQGxRgSSJ01N/\r
+ A/VycLAIqEpcm1oCEuYFOu9f50IWCFtQ4uTMJ2A2s4CWxI1/L5kmMArMQpKahSS1gJFpFaNs\r
+ Sm6Vbm5iZk5xarJucXJiXl5qka6pXm5miV5qSukmRlA4srso7WD8eVDpEKMAB6MSD++MwIdB\r
+ QqyJZcWVuYcYJTmYlER5p15+FCTEl5SfUpmRWJwRX1Sak1p8iFGCg1lJhHfuZqAcb0piZVVq\r
+ UT5MSpqDRUmc9xaHfZCQQHpiSWp2ampBahFMVoaDQ0mCV/86UKNgUWp6akVaZk4JQpqJgxNk\r
+ OA/QcBeQGt7igsTc4sx0iPwpRkUpcd4F14ASAiCJjNI8uF5YunjFKA70ijCvIUg7DzDVwHW/\r
+ AhrMBDR4xdkHIINLEhFSUg2M868w2IXwvk507MlY2XY2d0/NjFfBvPY2t1NOex+q2rzx1rVK\r
+ 0UMLVBjaI/Vu3/3dernow9f/CcUM6vwHpq+4JK14Uzx53bc72gFvnwrL3eX0z9/vVM+gkG32\r
+ 0XPLt8eRzVvFNy3Yu2py0NkDxhF9H7b9ujND9a/fxdZA5QtL7CcGhvb2mj4+rMRSnJFoqMVc\r
+ VJwIAKmjcxDyAgAA\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 24 Jan 2014 21:18:13 -0000\r
+\r
+On Thu, 09 Jan 2014, Jani Nikula <jani@nikula.org> wrote:\r
+> Hi all, this series makes the folder: search prefix literal, or switches\r
+> it from a probabilistic prefix to a boolean prefix. With this, you have\r
+> to give the path from the maildir root to the folder you want in full,\r
+> including the maildir cur/new component, if any. Examples:\r
+\r
+I strongly disagree with requiring the cur/new component. The cur/new\r
+directory is an internal implementation detail of Maildir (and a rather\r
+broken one at that) and no more a part of the "folder" of a piece of\r
+mail than its final file name component. It's also the less obvious\r
+user interface; if we require the cur/new component, we *will* get\r
+people asking why their folder searches aren't working, but if we strip\r
+the cur/new component, nobody will be surprised.\r
+\r
+I think the question is not whether we should strip cur/new, but when.\r
+We've already defined a "_filename_is_in_maildir" test in\r
+lib/message.cc, which we depend on for flag sync. It's simple, but I\r
+think this would be the right thing to use for consistency.\r
+\r
+> folder:cur\r
+> folder:foo/bar\r
+> folder:""\r
+>\r
+> The last one can be used to refer to the maildir root (note that in\r
+> shell you'll need quoting to pass the double quotes to xapian,\r
+> folder:'""').\r
+>\r
+> The old probabilistic folder: prefix is problematic in a number of\r
+> ways. It's not possible to refer to the maildir root. It does stemming,\r
+> so "inboxing" would match "inbox" too. "cur" for the folder in maildir\r
+> root would match all "cur" folders across the maildir hierarchy. Likely\r
+> some others I forgot.\r
+>\r
+> WARNING! The change requires a database format version bump, and a\r
+> database upgrade, which is automatically done on 'notmuch new'. The\r
+> upgrade is irreversible if you want to try this on your database! A\r
+> complete database rebuild is required for reverting the database format\r
+> version. Make sure your backups are in order!\r
+>\r
+> The series includes some tests, including an initial upgrade test, along\r
+> with a test database in the previous format version.\r
+>\r
+>\r
+> BR,\r
+> Jani.\r
+>\r
+>\r
+>\r
+> Jani Nikula (5):\r
+> lib: make folder: prefix literal\r
+> test: fix insert folder: searches\r
+> test: fix test for literal folder: search\r
+> test: add test database in format version 1\r
+> test: add database upgrade test from format version 1\r
+>\r
+> lib/database.cc | 39 ++++++++-\r
+> lib/message.cc | 154 +++++++++++++++++----------------\r
+> lib/notmuch-private.h | 3 +\r
+> test/insert | 10 +--\r
+> test/notmuch-test | 1 +\r
+> test/search-by-folder | 24 ++++-\r
+> test/test-databases/README | 5 ++\r
+> test/test-databases/database-v1.tar.gz | Bin 0 -> 252243 bytes\r
+> test/upgrade | 25 ++++++\r
+> 9 files changed, 174 insertions(+), 87 deletions(-)\r
+> create mode 100644 test/test-databases/README\r
+> create mode 100644 test/test-databases/database-v1.tar.gz\r
+> create mode 100755 test/upgrade\r
+>\r
+> -- \r
+> 1.8.5.2\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff