Re: [PATCH v3 15/16] added notmuch_message_reindex

diff --git a/eb/d5f2a939302a73a3b79a519eddd41e3e125c7b b/eb/d5f2a939302a73a3b79a519eddd41e3e125c7b
new file mode 100644 (file)
index 0000000..7f086a9
--- /dev/null
+++ b/eb/d5f2a939302a73a3b79a519eddd41e3e125c7b
@@ -0,0 +1,109 @@
+Return-Path: <dkg@fifthhorseman.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id C3B4C6DE0231\r
+ for <notmuch@notmuchmail.org>; Tue,  9 Feb 2016 17:01:47 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.019\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.019 tagged_above=-999 required=5\r
+ tests=[AWL=-0.019] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 5oLSQsf2_uTn for <notmuch@notmuchmail.org>;\r
+ Tue,  9 Feb 2016 17:01:45 -0800 (PST)\r
+Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 844586DE021E\r
+ for <notmuch@notmuchmail.org>; Tue,  9 Feb 2016 17:01:45 -0800 (PST)\r
+Received: from fifthhorseman.net (unknown [38.109.115.130])\r
+ by che.mayfirst.org (Postfix) with ESMTPSA id CE75DF997;\r
+ Tue,  9 Feb 2016 20:01:42 -0500 (EST)\r
+Received: by fifthhorseman.net (Postfix, from userid 1000)\r
+ id 682C51FF75; Tue,  9 Feb 2016 20:01:43 -0500 (EST)\r
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v3 15/16] added notmuch_message_reindex\r
+In-Reply-To: <87mvr9s8gy.fsf@servo.finestructure.net>\r
+References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1454272801-23623-16-git-send-email-dkg@fifthhorseman.net>\r
+ <87mvr9s8gy.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.21+72~gd8c4f1c (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 09 Feb 2016 20:01:43 -0500\r
+Message-ID: <87oabpnzt4.fsf@alice.fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: 8bit\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 10 Feb 2016 01:01:48 -0000\r
+\r
+On Tue 2016-02-09 19:41:01 -0500, Jameson Graef Rollins wrote:\r
+> On Sun, Jan 31 2016, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:\r
+>> This new function asks the database to reindex a given message, using\r
+>> the supplied indexopts.\r
+>>\r
+>> This can be used, for example, to index the cleartext of an encrypted\r
+>> message.\r
+>\r
+> I just wanted to mention that I think there's a problem with the reindex\r
+> functionality introduced in this patch (or in 16/16).  It looks like\r
+> this function irrevocably busts apart threads.  dkg and I are\r
+> investigating.\r
+\r
+it doesn't appear to be irrevocable to me, but it is definitely doing\r
+something weird with threading.\r
+\r
+we have a three message thread tagged "weird-thread":\r
+\r
+  ( a ← b ← c )\r
+\r
+if i do:\r
+\r
+   notmuch reindex id:a\r
+\r
+then we see two threads:\r
+\r
+  ( a ) , ( b ← c )\r
+\r
+if i then do:\r
+\r
+   notmuch reindex id:b\r
+\r
+then i see two threads:\r
+\r
+\r
+   ( a ← b ) ,  ( c )\r
+\r
+\r
+and if i then do:\r
+\r
+   notmuch reindex id:c\r
+\r
+then i see one thread again:\r
+\r
+   ( a ← b ← c )\r
+\r
+but interestingly, reindexing all the messages together by search tearm\r
+\r
+  notmuch reindex tag:weird-thread\r
+\r
+doesn't affect the threading.\r
+\r
+\r
+i think this is happening without regard to --try-decrypt, fwiw.\r
+\r
+  --dkg\r