--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 174EF431FAF\r
+ for <notmuch@notmuchmail.org>; Sun, 13 Oct 2013 00:25:28 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id i3oz49iX-oXy for <notmuch@notmuchmail.org>;\r
+ Sun, 13 Oct 2013 00:25:22 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id F1D6E431FAE\r
+ for <notmuch@notmuchmail.org>; Sun, 13 Oct 2013 00:25:21 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1VVG33-0001rM-9g; Sun, 13 Oct 2013 08:25:09 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1VVG32-0007PV-Po; Sun, 13 Oct 2013 08:25:09 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 1/2] emacs: show: use interactive instead of\r
+ current-prefix-arg\r
+In-Reply-To: <20131013033157.GE10539@mit.edu>\r
+References: <1381348886-5673-1-git-send-email-markwalters1009@gmail.com>\r
+ <1381348886-5673-2-git-send-email-markwalters1009@gmail.com>\r
+ <20131013033157.GE10539@mit.edu>\r
+User-Agent: Notmuch/0.15.2+334~gafd5c6a (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 13 Oct 2013 08:25:07 +0100\r
+Message-ID: <8761t13a5o.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 2a58f6129c5f8acb60553aee6a715217 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.0 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 Oct 2013 07:25:28 -0000\r
+\r
+\r
+On Sun, 13 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Code looks good. Two minor comments below.\r
+\r
+That's great. \r
+>\r
+> Quoth Mark Walters on Oct 09 at 9:01 pm:\r
+>> Currently notmuch-show looks at the prefix-arg directly via\r
+>> current-prefix-arg. This changes it to use the interactive\r
+>> specification.\r
+>> ---\r
+>> emacs/notmuch-show.el | 12 +++++++-----\r
+>> emacs/notmuch.el | 5 +++--\r
+>> 2 files changed, 10 insertions(+), 7 deletions(-)\r
+>> \r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index 5d7e24b..15f9ce6 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -1080,15 +1080,17 @@ buttons for a corresponding notmuch search."\r
+>> (make-text-button (first link) (second link)\r
+>> :type 'notmuch-button-type\r
+>> 'action `(lambda (arg)\r
+>> - (notmuch-show ,(third link)))\r
+>> + (notmuch-show ,(third link) current-prefix-arg))\r
+>\r
+> Hmm. Does this work? Can you activate the button with C-u RET?\r
+\r
+This does work: you can activate the button with C-u RET and it does\r
+elide the resulting the thread. (This is identical to the current\r
+behaviour)\r
+\r
+\r
+>\r
+>> 'follow-link t\r
+>> 'help-echo "Mouse-1, RET: search for this message"\r
+>> 'face goto-address-mail-face)))))\r
+>> \r
+>> ;;;###autoload\r
+>> -(defun notmuch-show (thread-id &optional parent-buffer query-context buffer-name)\r
+>> +(defun notmuch-show (thread-id &optional elide-toggle parent-buffer query-context buffer-name)\r
+>> "Run \"notmuch show\" with the given thread ID and display results.\r
+>> \r
+>> +The optional ELIDE-TOGGLE inverts the default elide behaviour.\r
+>\r
+> "ELIDE-TOGGLE, if non-nil, inverts the default elide behavior."?\r
+\r
+I will fix this.\r
+\r
+Thanks for the review\r
+\r
+Mark\r
+\r
+>\r
+>> +\r
+>> The optional PARENT-BUFFER is the notmuch-search buffer from\r
+>> which this notmuch-show command was executed, (so that the\r
+>> next thread from that buffer can be show when done with this\r
+>> @@ -1102,7 +1104,7 @@ The optional BUFFER-NAME provides the name of the buffer in\r
+>> which the message thread is shown. If it is nil (which occurs\r
+>> when the command is called interactively) the argument to the\r
+>> function is used."\r
+>> - (interactive "sNotmuch show: ")\r
+>> + (interactive "sNotmuch show: \nP")\r
+>> (let ((buffer-name (generate-new-buffer-name\r
+>> (or buffer-name\r
+>> (concat "*notmuch-" thread-id "*")))))\r
+>> @@ -1112,9 +1114,9 @@ function is used."\r
+>> (setq notmuch-show-process-crypto notmuch-crypto-process-mime)\r
+>> ;; Set the default value for\r
+>> ;; `notmuch-show-elide-non-matching-messages' in this buffer. If\r
+>> - ;; there is a prefix argument, invert the default.\r
+>> + ;; elide-toggle is set, invert the default.\r
+>> (setq notmuch-show-elide-non-matching-messages notmuch-show-only-matching-messages)\r
+>> - (if current-prefix-arg\r
+>> + (if elide-toggle\r
+>> (setq notmuch-show-elide-non-matching-messages (not notmuch-show-elide-non-matching-messages)))\r
+>> \r
+>> (setq notmuch-show-thread-id thread-id\r
+>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+>> index 0ff248b..7124d0a 100644\r
+>> --- a/emacs/notmuch.el\r
+>> +++ b/emacs/notmuch.el\r
+>> @@ -486,13 +486,14 @@ If BARE is set then do not prefix with \"thread:\""\r
+>> "Return a list of authors for the current region"\r
+>> (notmuch-search-properties-in-region :subject beg end))\r
+>> \r
+>> -(defun notmuch-search-show-thread ()\r
+>> +(defun notmuch-search-show-thread (&optional elide-toggle)\r
+>> "Display the currently selected thread."\r
+>> - (interactive)\r
+>> + (interactive "P")\r
+>> (let ((thread-id (notmuch-search-find-thread-id))\r
+>> (subject (notmuch-search-find-subject)))\r
+>> (if (> (length thread-id) 0)\r
+>> (notmuch-show thread-id\r
+>> + elide-toggle\r
+>> (current-buffer)\r
+>> notmuch-search-query-string\r
+>> ;; Name the buffer based on the subject.\r
projects / notmuch-archives.git / commitdiff