Re: [PATCH 01/18] cli: add stub for insert command

diff --git a/cb/12e5aeba3ce7b471931bdcab8856c0a94fb25d b/cb/12e5aeba3ce7b471931bdcab8856c0a94fb25d
new file mode 100644 (file)
index 0000000..2e3a27c
--- /dev/null
+++ b/cb/12e5aeba3ce7b471931bdcab8856c0a94fb25d
@@ -0,0 +1,95 @@
+Return-Path: <novalazy@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 59D94431FBF\r
+       for <notmuch@notmuchmail.org>; Mon, 19 Nov 2012 04:34:42 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id lF1vdQocbi6F for <notmuch@notmuchmail.org>;\r
+       Mon, 19 Nov 2012 04:34:41 -0800 (PST)\r
+Received: from mail-da0-f53.google.com (mail-da0-f53.google.com\r
+       [209.85.210.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id BD18E431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 19 Nov 2012 04:34:41 -0800 (PST)\r
+Received: by mail-da0-f53.google.com with SMTP id g9so2709805dad.26\r
+       for <notmuch@notmuchmail.org>; Mon, 19 Nov 2012 04:34:41 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=date:message-id:from:to:cc:subject:in-reply-to:references\r
+       :mime-version:content-type:content-disposition\r
+       :content-transfer-encoding;\r
+       bh=rXS0kAfS3iC3L6tE2VtxJoY2Rflx6BdOW8tV2BXNQxQ=;\r
+       b=q9O0PwlHShWB3MvMQpokskQ87EQxAllX6HMoR6Jjn/rGeMnl0e3RGRX06EcR0iadSJ\r
+       D/nXDpXBgFyzaWfn32fpNojoF1+96w7KeARePHCj5xFOKFg2lcSHxj77iqMDVnsW2Rmf\r
+       jUuEKcaY9f9xK3h1mKFvjpf/NNzE2G1vcHBEnQ3+Qj2DcYuEC7z0m0NdCFgAF0uZAEsj\r
+       sCV+Upz0ZkRj42j8rOfS9H2faCQrlKgfgxpIloQQJ7WaQsvqCZc+H4JshCdYFPBNAbZb\r
+       RLuIQpELn0+f+dfdo9HoNwX+OD0wJhZBcMBl6n64IaSjuEKTDaS6JU/QFIrCp+oALmgU\r
+       Xpqg==\r
+Received: by 10.68.230.105 with SMTP id sx9mr38701368pbc.44.1353328481064;\r
+       Mon, 19 Nov 2012 04:34:41 -0800 (PST)\r
+Received: from localhost (215.42.233.220.static.exetel.com.au.\r
+       [220.233.42.215])\r
+       by mx.google.com with ESMTPS id e9sm6127081paz.28.2012.11.19.04.34.38\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 19 Nov 2012 04:34:39 -0800 (PST)\r
+Date: Mon, 19 Nov 2012 23:34:35 +1100\r
+Message-ID: <20121119233435.GD2063@hili.localdomain>\r
+From: Peter Wang <novalazy@gmail.com>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 01/18] cli: add stub for insert command\r
+In-Reply-To: <87fw46q0f7.fsf@qmul.ac.uk>\r
+References: <1343223767-9812-1-git-send-email-novalazy@gmail.com>\r
+       <87fw46q0f7.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: 8bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 19 Nov 2012 12:34:42 -0000\r
+\r
+On Sun, 18 Nov 2012 17:35:23 +0000, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> \r
+> Hi\r
+> \r
+> I have now been through essentially the whole series (except the tests)\r
+> and broadly like it. Just to summarise my concerns from the individual\r
+> replies here:\r
+\r
+Thanks for the review.\r
+\r
+> \r
+> What should insert do when interrupted and is it safe? I am not\r
+> knowledgeable enough to be confident about that.\r
+\r
+Do you mean cleaning up stray files?  Otherwise I think we just return\r
+an error code, and then it's the caller's responsibility.\r
+\r
+> \r
+> I think some of the talloc allocations need their return values\r
+> checked. I am more worried about this here then in most of the rest of\r
+> notmuch as we are writing to the database (and even to the mailstore\r
+> itself).\r
+\r
+Will do.\r
+\r
+Peter\r