Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists

diff --git a/ef/641b4812e223784056c927299f3fe1c2e85f60 b/ef/641b4812e223784056c927299f3fe1c2e85f60
new file mode 100644 (file)
index 0000000..8b4ab49
--- /dev/null
+++ b/ef/641b4812e223784056c927299f3fe1c2e85f60
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 498EE6DE012F\r
+ for <notmuch@notmuchmail.org>; Mon, 11 Apr 2016 18:28:58 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.017\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.017 tagged_above=-999 required=5\r
+ tests=[AWL=-0.006, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id ki3772sXJuuR for <notmuch@notmuchmail.org>;\r
+ Mon, 11 Apr 2016 18:28:50 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 3A9646DE0127\r
+ for <notmuch@notmuchmail.org>; Mon, 11 Apr 2016 18:28:50 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1apn8R-0003iM-21; Mon, 11 Apr 2016 21:28:55 -0400\r
+Received: (nullmailer pid 20964 invoked by uid 1000);\r
+ Tue, 12 Apr 2016 01:28:44 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Cc: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH v4 7/7] complete\r
+ ghost-on-removal-when-shared-thread-exists\r
+In-Reply-To: <87zit0t0mj.fsf@alice.fifthhorseman.net>\r
+References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net>\r
+ <87r3ed6l35.fsf@zancas.localnet> <87zit0t0mj.fsf@alice.fifthhorseman.net>\r
+User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 11 Apr 2016 22:28:44 -0300\r
+Message-ID: <87wpo362er.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 12 Apr 2016 01:28:58 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+\r
+> I don't think this reasoning is sensible.  If the entire thread is\r
+> deleted, and a new message comes in, it should *not* get the same mesage\r
+> ID.  ghosts should only exist in the database when other messages point\r
+> to them.\r
+>\r
+> So i'd be fine with killing this entire last test, unless someone can\r
+> propose a good reason to keep it.\r
+\r
+I think I buy your reasoning, but I'd be happy if Austin (who introduced\r
+ghost messages, and wrote that test, could comment.\r
+\r
+d\r