Re: [PATCH 0/2] emacs: show: use interactive instead of current-prefix-arg

diff --git a/79/b3a3f1b3c2260525c4b53f0b20a55db5d13e4b b/79/b3a3f1b3c2260525c4b53f0b20a55db5d13e4b
new file mode 100644 (file)
index 0000000..85bbc88
--- /dev/null
+++ b/79/b3a3f1b3c2260525c4b53f0b20a55db5d13e4b
@@ -0,0 +1,89 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1D194431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 10 Oct 2013 03:21:51 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id tBTukexWZhrJ for <notmuch@notmuchmail.org>;\r
+       Thu, 10 Oct 2013 03:21:45 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8AB90431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 10 Oct 2013 03:21:45 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id E76B8100030;\r
+       Thu, 10 Oct 2013 13:21:37 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/2] emacs: show: use interactive instead of\r
+       current-prefix-arg\r
+In-Reply-To: <1381348886-5673-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1381348886-5673-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.16+87~g451fefe (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 10 Oct 2013 13:21:37 +0300\r
+Message-ID: <m2siw91l5a.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 10 Oct 2013 10:21:51 -0000\r
+\r
+On Wed, Oct 09 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> This is a tidied up version of the patch at\r
+> id:1380729013-3942-1-git-send-email-markwalters1009@gmail.com\r
+> (incorporating suggestions from Tomi in\r
+> id:m2siwjhapc.fsf@guru.guru-group.fi)\r
+>\r
+> This helps fix a problem in pick but there was reasonable agreement on\r
+> irc that show should not be looking at current-prefix-arg directly.\r
+>\r
+> One test needs to be changed to the new behaviour.\r
+\r
+LGTM. Having elide-toggle &optional looks like a very good idea!\r
+\r
+Tomi\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+> Mark Walters (2):\r
+>   emacs: show: use interactive instead of current-prefix-arg\r
+>   test: emacs-show: fix use of prefix-arg\r
+>\r
+>  emacs/notmuch-show.el |   12 +++++++-----\r
+>  emacs/notmuch.el      |    5 +++--\r
+>  test/emacs-show       |    3 +--\r
+>  3 files changed, 11 insertions(+), 9 deletions(-)\r
+>\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r