Re: [PATCH v3 09/10] cli: address: Add --output=count

diff --git a/f2/814ec1afa144ca17949b376afe8d3da4d31fbb b/f2/814ec1afa144ca17949b376afe8d3da4d31fbb
new file mode 100644 (file)
index 0000000..2dbe35d
--- /dev/null
+++ b/f2/814ec1afa144ca17949b376afe8d3da4d31fbb
@@ -0,0 +1,80 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1958B431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  5 Nov 2014 12:58:33 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Y5FWkzwJsn6l for <notmuch@notmuchmail.org>;\r
+       Wed,  5 Nov 2014 12:58:25 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 22BB8431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  5 Nov 2014 12:58:25 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 8EE9C100033;\r
+       Wed,  5 Nov 2014 22:57:54 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 09/10] cli: address: Add --output=count\r
+In-Reply-To: <1415147159-19946-10-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1415147159-19946-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <1415147159-19946-10-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.18.2+169~g5bcdd1c (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 05 Nov 2014 22:57:54 +0200\r
+Message-ID: <m21tph1i25.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 05 Nov 2014 20:58:33 -0000\r
+\r
+On Wed, Nov 05 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+\r
+> This output prints how many times was each address encountered during\r
+> search.\r
+> ---\r
+> [ nn lines removed]\r
+>\r
+>      ``--sort=``\ (**newest-first**\ \|\ **oldest-first**)\r
+>          This option can be used to present results in either\r
+>          chronological order (**oldest-first**) or reverse chronological\r
+> @@ -56,6 +63,8 @@ Supported options for **address** include\r
+>          By default, results will be displayed in reverse chronological\r
+>          order, (that is, the newest results will be displayed first).\r
+>  \r
+> +    This option has no effect when used with --output=count.\r
+\r
+This is not entirely true -- the order the addresses are gathered will\r
+affect how the hash table is built up and it may affect how the addresses\r
+are printed (unless the --sort option is ignored when --count is given,\r
+which does not seem to be the case). \r
+\r
+The question is whether the accuracy of this message matters; some\r
+nitpickers might complain ;)\r
+\r
+Anyway, +1 from me to patches 1 - 9 -- these things could still be\r
+adjusted when NEWS patch of the feature is prepared.\r
+\r
+\r
+Tomi\r