[Patch v2 1/4] cli: ignore config argument of notmuch_help_command

diff --git a/d5/b7a8bc6b37df3af9dec676e72e5ae1ed9c97b0 b/d5/b7a8bc6b37df3af9dec676e72e5ae1ed9c97b0
new file mode 100644 (file)
index 0000000..e919781
--- /dev/null
+++ b/d5/b7a8bc6b37df3af9dec676e72e5ae1ed9c97b0
@@ -0,0 +1,88 @@
+Return-Path: <bremner@tesseract.cs.unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 3045A6DE1AEA\r
+ for <notmuch@notmuchmail.org>; Mon,  6 Apr 2015 05:24:29 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.467\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.467 tagged_above=-999 required=5 tests=[AWL=0.457, \r
+ T_HEADER_FROM_DIFFERENT_DOMAINS=0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id ZplKL_UUhihJ for <notmuch@notmuchmail.org>;\r
+ Mon,  6 Apr 2015 05:24:27 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+ [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 3B7EE6DE1AC6\r
+ for <notmuch@notmuchmail.org>; Mon,  6 Apr 2015 05:24:27 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+ 4.80) (envelope-from <bremner@tesseract.cs.unb.ca>)\r
+ id 1Yf649-000593-8c; Mon, 06 Apr 2015 12:23:45 +0000\r
+Received: (nullmailer pid 3280 invoked by uid 1000); Mon, 06 Apr 2015\r
+ 12:22:58 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: [Patch v2 1/4] cli: ignore config argument of notmuch_help_command\r
+Date: Mon,  6 Apr 2015 21:22:35 +0900\r
+Message-Id: <1428322958-2887-2-git-send-email-david@tethera.net>\r
+X-Mailer: git-send-email 2.1.4\r
+In-Reply-To: <1428322958-2887-1-git-send-email-david@tethera.net>\r
+References: <87d23ixnr7.fsf@maritornes.cs.unb.ca>\r
+ <1428322958-2887-1-git-send-email-david@tethera.net>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 06 Apr 2015 12:24:29 -0000\r
+\r
+We call it with NULL at one point anyway, so it needs to work with\r
+NULL. Since the only place we use talloc is right before exec, there\r
+is no harm in always using NULL.\r
+---\r
+ notmuch.c | 6 +++---\r
+ 1 file changed, 3 insertions(+), 3 deletions(-)\r
+\r
+diff --git a/notmuch.c b/notmuch.c\r
+index a5b2877..31672c3 100644\r
+--- a/notmuch.c\r
++++ b/notmuch.c\r
+@@ -177,7 +177,7 @@ exec_man (const char *page)\r
+ }\r
+ \r
+ static int\r
+-notmuch_help_command (notmuch_config_t *config, int argc, char *argv[])\r
++notmuch_help_command (unused (notmuch_config_t * config), int argc, char *argv[])\r
+ {\r
+     command_t *command;\r
+     help_topic_t *topic;\r
+@@ -202,14 +202,14 @@ notmuch_help_command (notmuch_config_t *config, int argc, char *argv[])\r
+ \r
+     command = find_command (argv[0]);\r
+     if (command) {\r
+-      char *page = talloc_asprintf (config, "notmuch-%s", command->name);\r
++      char *page = talloc_asprintf (NULL, "notmuch-%s", command->name);\r
+       exec_man (page);\r
+     }\r
+ \r
+     for (i = 0; i < ARRAY_SIZE (help_topics); i++) {\r
+       topic = &help_topics[i];\r
+       if (strcmp (argv[0], topic->name) == 0) {\r
+-          char *page = talloc_asprintf (config, "notmuch-%s", topic->name);\r
++          char *page = talloc_asprintf (NULL, "notmuch-%s", topic->name);\r
+           exec_man (page);\r
+       }\r
+     }\r
+-- \r
+2.1.4\r
+\r