projects / git.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 168c1e0)
gitweb: esc_html() site name for title in OPML
authorJürgen Kreileder <jk@blackdown.de>
Sat, 17 Dec 2011 09:22:22 +0000 (10:22 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 19 Dec 2011 03:44:51 +0000 (19:44 -0800)
This escapes the site name in OPML (XML uses the same escaping rules
as HTML).  Also fixes encoding issues because esc_html() uses
to_utf8().

Signed-off-by: Jürgen Kreileder <jk@blackdown.de>
Acked-by: Jakub Narębski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitweb/gitweb.perl patch | blob | history

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index b07703253244e20e3e3c87c5ba7a89b672c491a0..a9f39d59cdaec0880106cbdd03f4011d034d9de8 100755 (executable)
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -7700,11 +7700,12 @@ sub git_opml {
                -charset => 'utf-8',
                -content_disposition => 'inline; filename="opml.xml"');
 
+       my $title = esc_html($site_name);
        print <<XML;
 <?xml version="1.0" encoding="utf-8"?>
 <opml version="1.0">
 <head>
-  <title>$site_name OPML Export</title>
+  <title>$title OPML Export</title>
 </head>
 <body>
 <outline text="git RSS feeds">
Git—the stupid content tracker