Re: [PATCH] add has: query prefix to search for specific properties

diff --git a/c1/cfdbfaa3448c4a3168c315340dc361da223de1 b/c1/cfdbfaa3448c4a3168c315340dc361da223de1
new file mode 100644 (file)
index 0000000..9ca340d
--- /dev/null
+++ b/c1/cfdbfaa3448c4a3168c315340dc361da223de1
@@ -0,0 +1,95 @@
+Return-Path: <dkg@fifthhorseman.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 836216DE01F9\r
+ for <notmuch@notmuchmail.org>; Sun, 17 Jul 2016 16:44:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.000]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id xBo_lWzYjXG3 for <notmuch@notmuchmail.org>;\r
+ Sun, 17 Jul 2016 16:44:29 -0700 (PDT)\r
+Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 706596DE01CE\r
+ for <notmuch@notmuchmail.org>; Sun, 17 Jul 2016 16:44:29 -0700 (PDT)\r
+Received: from fifthhorseman.net (p4FCDEE1A.dip0.t-ipconnect.de\r
+ [79.205.238.26])\r
+ by che.mayfirst.org (Postfix) with ESMTPSA id C930B1037F;\r
+ Sun, 17 Jul 2016 19:44:28 -0400 (EDT)\r
+Received: by fifthhorseman.net (Postfix, from userid 1000)\r
+ id 9C6B41FF54; Mon, 18 Jul 2016 01:44:27 +0200 (CEST)\r
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+To: David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH] add has: query prefix to search for specific properties\r
+In-Reply-To: <87ziphxfl2.fsf@zancas.localnet>\r
+References: <1465779955-5539-9-git-send-email-david@tethera.net>\r
+ <1467969336-7605-1-git-send-email-dkg@fifthhorseman.net>\r
+ <87ziphxfl2.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.22+77~gaba8744 (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 18 Jul 2016 01:44:27 +0200\r
+Message-ID: <8760s36d9g.fsf@alice.fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 17 Jul 2016 23:44:37 -0000\r
+\r
+On Sun 2016-07-17 02:39:53 +0200, David Bremner wrote:\r
+> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+>\r
+>> We want to be able to query the properties directly, like:\r
+>>\r
+>>    notmuch count has:foo=bar\r
+>>\r
+>> which should return a count of messages where the property with key\r
+>> "foo" has value equal to "bar".\r
+>>\r
+>> This patch could be improved:\r
+>>\r
+>> If no = sign is present (e.g. "has:foo"), it'd be nice to just match\r
+>>  on every message that has property "foo", regardless of value.\r
+>\r
+> At the moment I can't think of a nice easy way to do this.  It could do\r
+> something like that proposed for "tag:*", namely expand it internally\r
+> into an or query, by traversing the\r
+> db->allterms_begin("XPROPERTY"). \r
+>\r
+>> It would also be good to include some tests.\r
+>\r
+> and update notmuch-search-terms(7) ?\r
+\r
+yes, please -- patches welcome ;)\r
+\r
+an attempt to describe the distinction between "tags" and "properties":\r
+\r
+Tags are user-settable and user-fetchable, and automated systems are\r
+discouraged from adding them (we have some legacy exceptions like\r
+"inbox" and "unread" and "signed" and "encrypted").  Tags are generally\r
+expected to be simple textual labels.\r
+\r
+Properties are user-fetchable, but should only be set by automated\r
+systems.  Properties are key=value pairs (though a given message can\r
+have any number of properties with the same key), and while the key is\r
+expected to be a textual string (printable characters except for "=")\r
+and the value can potentially be arbitrary binary data.\r
+\r
+I welcome edits on this text if it doesn't capture your current sense of\r
+the distinction.\r
+\r
+     --dkg\r