Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

diff --git a/cc/94934c2a042ec3b260b82637cdcc5ea39f9331 b/cc/94934c2a042ec3b260b82637cdcc5ea39f9331
new file mode 100644 (file)
index 0000000..f5ca5c4
--- /dev/null
+++ b/cc/94934c2a042ec3b260b82637cdcc5ea39f9331
@@ -0,0 +1,97 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E2D90431FBD\r
+       for <notmuch@notmuchmail.org>; Tue,  9 Apr 2013 04:50:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id XOKiiiQExxYp for <notmuch@notmuchmail.org>;\r
+       Tue,  9 Apr 2013 04:50:24 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 19399431FAE\r
+       for <notmuch@notmuchmail.org>; Tue,  9 Apr 2013 04:50:24 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UPX43-0001Cx-KY; Tue, 09 Apr 2013 08:50:16 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UPX3x-0007wy-Q6; Tue, 09 Apr 2013 08:50:09 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, Jed Brown <jed@59A2.org>,\r
+       Jani Nikula <jani@nikula.org>, Karl Fogel <kfogel@red-bean.com>,\r
+       Daniel Bergey <bergey@alum.mit.edu>\r
+Subject: Re: [PATCH] emacs: add missing paren to fix defun in\r
+       notmuch-address.el.\r
+In-Reply-To: <m2hajgxli5.fsf@guru.guru-group.fi>\r
+References: <87wqsfik5l.fsf@floss.red-bean.com>\r
+       <87mwtah2hd.fsf@zancas.localnet>\r
+       <877gkeau42.fsf@floss.red-bean.com>\r
+       <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
+       <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
+       <m2hajgxli5.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.15.2+73~g1c450ec (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 09 Apr 2013 08:50:09 -0300\r
+Message-ID: <87vc7vgbym.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 09 Apr 2013 11:50:25 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> On Tue, Apr 09 2013, Jed Brown wrote:\r
+>\r
+>> David Bremner <david@tethera.net> writes:\r
+>>\r
+>>> Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to\r
+>>> do it myself.\r
+>>\r
+>> I tested the attached and it's working as expected.  Sent as an\r
+>> attachment to preserve author information.\r
+>\r
+> LGTM (this time tested, too). Also compared diffs by hand, change as announced.\r
+> comments in id:m26207wgyt.fsf@guru.guru-group.fi (amend!) apply. \r
+\r
+There seems to be a few warnings:\r
+\r
+In notmuch-bbdb/snarf-from:\r
+notmuch-address.el:116:26:Warning: reference to free variable\r
+    `bbdb-get-addresses-headers'\r
+\r
+In notmuch-bbdb/snarf-to:\r
+notmuch-address.el:122:29:Warning: reference to free variable\r
+    `bbdb-get-addresses-headers'\r
+\r
+In end of data:\r
+notmuch-address.el:143:1:Warning: the following functions are not known to be\r
+    defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header\r
+\r
+Do we need a few defvars?\r
+\r
+d\r