Drop the version attribute on the generator tag in Atom feeds.
authorPaul Wise <pabs3@bonedaddy.net>
Tue, 28 Feb 2012 15:14:20 +0000 (23:14 +0800)
committerJoey Hess <joey@kitenet.net>
Sat, 3 Mar 2012 15:01:55 +0000 (11:01 -0400)
Removing the version means that rebuilds are reproducible over time.

Both the generator tag and its version attribute are optional:

http://tools.ietf.org/html/rfc4287#section-4.2.4

IkiWiki/Plugin/inline.pm
templates/atompage.tmpl

index 159cc5def01d59aaa3f532cbb4fea14ab52f6435..bdab5793b7c8a611ebb4bbfb7c1ff0951218712c 100644 (file)
@@ -677,7 +677,6 @@ sub genfeed ($$$$$@) {
                guid => $guid,
                feeddate => date_3339($lasttime),
                feedurl => $feedurl,
-               version => $IkiWiki::version,
        );
        run_hooks(pagetemplate => sub {
                shift->(page => $page, destpage => $page,
index e82b59827c0c68c1ec2a9ce813fce1c367cfb995..3cdd71d1ad2ab62698b3a6285a65b3dc728bd5d9 100644 (file)
@@ -33,7 +33,7 @@
 <id><TMPL_VAR PAGEURL></id>
 </TMPL_IF>
 <subtitle type="html"><TMPL_VAR FEEDDESC ESCAPE=HTML></subtitle>
-<generator uri="http://ikiwiki.info/" version="<TMPL_VAR VERSION>">ikiwiki</generator>
+<generator uri="http://ikiwiki.info/">ikiwiki</generator>
 <updated><TMPL_VAR FEEDDATE></updated>
 <TMPL_VAR CONTENT>
 </feed>