Re: [PATCH 0/3] Introduce the add command

diff --git a/69/1fbe13c7b9a74d651cbd3378c2e194c2810aff b/69/1fbe13c7b9a74d651cbd3378c2e194c2810aff
new file mode 100644 (file)
index 0000000..05ce21b
--- /dev/null
+++ b/69/1fbe13c7b9a74d651cbd3378c2e194c2810aff
@@ -0,0 +1,105 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 238E0431FBF\r
+       for <notmuch@notmuchmail.org>; Wed, 17 Jul 2013 08:23:23 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id R1UfDXBbnxiG for <notmuch@notmuchmail.org>;\r
+       Wed, 17 Jul 2013 08:23:15 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id AC5B5431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 17 Jul 2013 08:23:15 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id A0813100030;\r
+       Wed, 17 Jul 2013 18:23:07 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/3] Introduce the add command\r
+In-Reply-To: <1373762746-22308-1-git-send-email-awg+notmuch@xvx.ca>\r
+References: <1373762746-22308-1-git-send-email-awg+notmuch@xvx.ca>\r
+User-Agent: Notmuch/0.15.2+193~g7350bd4 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 17 Jul 2013 18:23:07 +0300\r
+Message-ID: <m2wqop1a90.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 17 Jul 2013 15:23:23 -0000\r
+\r
+On Sun, Jul 14 2013, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:\r
+\r
+> Hi everyone,\r
+>\r
+> The recent introduction of insert inspired me to finally add a feature I've\r
+> been wanting: a command to index a specific file in the maildir. My usecase\r
+> for this is that I have an inotify-based script that watches for new mail\r
+> and calls notmuch new when new mail shows up. Running notmuch new in this\r
+> situation is overkill, since I know exactly what's changed. A faster command\r
+> that just adds a single file reduces contention on the database lock.\r
+>\r
+> This series introduces a new command, "notmuch add", which indexes a file\r
+> that already exists in the maildir. It is implemented in notmuch-insert.c\r
+> because it uses the basic infrastructure introduced for the insert command.\r
+>\r
+> Missing man page for now - wanted to get the code out first for review.\r
+\r
+The code looks good to me. \r
+\r
+The only issue I noticed when comparing with new is that check for notmuch\r
+database upgrade (and actual upgrade) is not done...\r
+\r
+... nor is this done in notmuch insert either.\r
+\r
+Maybe in these cases it is better than the upgrade is not attempted but\r
+it might be good to address this in the namual page (here and in insert\r
+page) ?\r
+\r
+Anyway I like the feature and would take it into use sometime in the\r
+(distant?) future (i.e. when I'd tune my mail delivery again).\r
+\r
+>\r
+> -- Adam\r
+\r
+Tomi\r
+\r
+>\r
+> Adam Wolfe Gordon (3):\r
+>   cli: Return an error code from add_message_to_database\r
+>   cli: Introduce the add command\r
+>   test: Add simple tests for the add command\r
+>\r
+>  notmuch-client.h |    3 +++\r
+>  notmuch-insert.c |   57 +++++++++++++++++++++++++++++++++++++++++++++++++++---\r
+>  notmuch.c        |    2 ++\r
+>  test/insert      |   35 +++++++++++++++++++++++++++++++++\r
+>  4 files changed, 94 insertions(+), 3 deletions(-)\r
+>\r
+> -- \r
+> 1.7.9.5\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r