Re: precedence in `notmuch-search-line-faces'

diff --git a/6d/04b9d13265c3c9acf4fdb395efa5503323cae7 b/6d/04b9d13265c3c9acf4fdb395efa5503323cae7
new file mode 100644 (file)
index 0000000..b706945
--- /dev/null
+++ b/6d/04b9d13265c3c9acf4fdb395efa5503323cae7
@@ -0,0 +1,114 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1F0C9429E37\r
+       for <notmuch@notmuchmail.org>; Sun,  4 May 2014 00:32:17 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.502\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.502 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 9deuIncNtZyo for <notmuch@notmuchmail.org>;\r
+       Sun,  4 May 2014 00:32:11 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D9D95431FD6\r
+       for <notmuch@notmuchmail.org>; Sun,  4 May 2014 00:32:10 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Wgqu0-0000GQ-Ij; Sun, 04 May 2014 08:32:02 +0100\r
+Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Wgqu0-0007qp-7r; Sun, 04 May 2014 08:32:00 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: precedence in `notmuch-search-line-faces'\r
+In-Reply-To: <cunmwf0h1q7.fsf@hotblack-desiato.hh.sledj.net>\r
+References: <cunmwf0h1q7.fsf@hotblack-desiato.hh.sledj.net>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 04 May 2014 08:31:59 +0100\r
+Message-ID: <87mwey3spc.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 87.81.223.162\r
+X-QM-Geographic: According to ripencc,\r
+       this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: b6591f8fce483044b55f248c925836e3 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -0.1 points.\r
+       Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 04 May 2014 07:32:17 -0000\r
+\r
+\r
+I have a slight preference for making it do the comment (ie reverse the\r
+list). My reason is that we have some other cases such as\r
+notmuch-tag-format that apply the first match, so users might be used to\r
+having the specific first and the more general later.\r
+\r
+It also has a small advantage of being less disruptive but, given that I\r
+don't think any of us realised it changed, I guess most people aren't\r
+using multiple matches.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+On Fri, 02 May 2014, David Edmondson <dme@dme.org> wrote:\r
+> The documentation for `notmuch-search-line-faces' says:\r
+>\r
+>> The attributes defined for matching tags are merged, with later\r
+>> attributes overriding earlier.\r
+>\r
+> A comment in `notmuch-search-color-line', which implements this, says:\r
+>\r
+>> ;; Reverse the list so earlier entries take precedence\r
+>\r
+> Clearly these two are at odds. The implementation of\r
+> `notmuch-search-color-line' follows the comment. That is, earlier\r
+> entries in the list take precedence.\r
+>\r
+> The original implementation of `notmuch-search-color-line' followed the\r
+> documentation of the user-visible variable, but this was changed by\r
+> commit 60ebc849 in July 2012.\r
+>\r
+> I'm inclined to go with the documentation and change the implementation,\r
+> but this could obviously ruin things for some users until they reorder\r
+> their settings.\r
+>\r
+> Thoughts?\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r