--- /dev/null
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 76F6E6DE0BF6\r
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 13:05:31 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.236\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.236 tagged_above=-999 required=5 tests=[AWL=0.334,\r
+ DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7,\r
+ RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 5zcP7GkW4j5h for <notmuch@notmuchmail.org>;\r
+ Wed, 10 Feb 2016 13:05:29 -0800 (PST)\r
+Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com\r
+ [74.125.82.65]) by arlo.cworth.org (Postfix) with ESMTPS id 2882C6DE0B36 for\r
+ <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 13:05:29 -0800 (PST)\r
+Received: by mail-wm0-f65.google.com with SMTP id c200so6711228wme.0\r
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 13:05:29 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=aYyK8J7ZlfylLkp6CLJVp27u2O0p3pUzJHowm3+Pocg=;\r
+ b=I3rLZRKTU+dIX9XywReWMnV9o49iksYRHgrtcVQeh7VIqUvCujz/fD/qTXPi0QEJBf\r
+ dBoGPfFAggEL2qyzeC9Z22b/gqaJOHLoROPOzGSc/lcc+jf2zT5wTpnv/NDHbXbHTcas\r
+ kLgTV7ZNdcbUQDwbibVZJo19YE6ufsRm4jXFRqaaqDLmSY2ZTvyYd0nTq1YadS+Eyjh1\r
+ IUmAN+/33TNWcxLJW5FNjqFB915sdwWk/33qYhxa9fsGAobOWTrwgMFwst7i82o7bhzs\r
+ CtsqrwhW6yb2vp4wTRlIRyB42A5VHk5rYm+2z8bhmkP1Woobtu3Pe9kMqCMtz2AnOPC8\r
+ aDJg==\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+ :user-agent:date:message-id:mime-version:content-type;\r
+ bh=aYyK8J7ZlfylLkp6CLJVp27u2O0p3pUzJHowm3+Pocg=;\r
+ b=g9/N1+Ak5SdN6e00zMX+3bRfGjiQoHmrK20gB1y74bF3DVsyrsZsWtiNGyD3OYJGXA\r
+ WKrhnWnc0s1ZIYzuKB4WwL+Ha+TCalrxI+1jDHmPUy/d3nM4syHBwk+uyZ8qLM5Gkeyb\r
+ s1p3HLOkgn9HvhtVbl5ATnVfMp6Q8KZGX19tEZ0OxMfpUrSlcZcY/qCk2q0qqaFv9TXU\r
+ jICBcM8nEwyi52N55gqu2sTFrQIcBl6nfoj6cKGP/X8q3lLTW39SzFzz9cnqsyB9mSV+\r
+ Y9uhbgqf2ffVlPMcV6aU0hvmD/SL6j0NkHLPABlKBtWlEquz3GiE5teqnljQr0yE2KKJ\r
+ 4jUw==\r
+X-Gm-Message-State:\r
+ AG10YORevTE9Me3bfhUXM9etm05UoEuKh+USFcmSf+8TLtOWa3Msy1bAaXTteA3K+Eygcg==\r
+X-Received: by 10.28.210.143 with SMTP id j137mr13161038wmg.13.1455138327703; \r
+ Wed, 10 Feb 2016 13:05:27 -0800 (PST)\r
+Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])\r
+ by smtp.gmail.com with ESMTPSA id c7sm5035587wmd.13.2016.02.10.13.05.26\r
+ (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Wed, 10 Feb 2016 13:05:27 -0800 (PST)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: Report a lack of matches when calling\r
+ `notmuch-show'.\r
+In-Reply-To: <m260xw2vim.fsf@dme.org>\r
+References: <1455112878-23497-1-git-send-email-dme@dme.org>\r
+ <1455112878-23497-2-git-send-email-dme@dme.org> <87oabo5rix.fsf@qmul.ac.uk>\r
+ <m260xw2vim.fsf@dme.org>\r
+User-Agent: Notmuch/0.18.1+485~gca076ce (http://notmuchmail.org) Emacs/24.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 10 Feb 2016 21:05:25 +0000\r
+Message-ID: <87lh6s5l9m.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 10 Feb 2016 21:05:31 -0000\r
+\r
+\r
+On Wed, 10 Feb 2016, David Edmondson <dme@dme.org> wrote:\r
+> On Wed, Feb 10 2016, Mark Walters wrote:\r
+>> This basically looks fine to me and all tests pass. The code movement\r
+>> and cleanup all looks fine.\r
+>\r
+> Thanks.\r
+>\r
+>> Two minor things, one tiny nit below; and I wonder whether just having\r
+>> the buffer say "No search results" (or something similar) and leave\r
+>> the user to kill it would be nicer than dinging (and more in line with\r
+>> the way search and tree behave).\r
+>>\r
+>> [In some sense I think this way is right and search and tree are wrong,\r
+>> but that is probably difficult to get round as search and tree run\r
+>> asynchronously.]\r
+>\r
+> What if we did "notmuch count $query" first in the search and tree case,\r
+> and did the "(ding) (message ...)" thing if the count returned 0? (Just\r
+> wondering about whether having everything behave that way would be\r
+> possible and acceptable.)\r
+>\r
+> The original impetus for this change was someone who hits an id: button\r
+> that is either a false match (i.e it wasn't ever intended to be a\r
+> notmuch reference) or for a message that they don't have. In both of\r
+> those cases popping up a buffer that says only "No match." would be\r
+> annoying. If we were considering the case where people are using "M-x\r
+> notmuch-show", it seems less clear on the right thing to do, but overall\r
+> I prefer this approach to the useless buffer that I have to kill/quit.\r
+>\r
+\r
+I am quite happy to leave it as you have it with the ding; currently we\r
+have an obscure error message and this is obviously better so (with the\r
+comment change below) +1 from me.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+>>> + ;; Cache the original tags for each message so that we can display\r
+>>> + ;; changes.\r
+>>\r
+>> ^^ I think "Store the original tags for each message" would be better,\r
+>> particularly as this is nothing to do with the tag cache as used by say\r
+>> notmuch-tag-clear-cache.\r
+>\r
+> Agreed - fixed.\r
projects / notmuch-archives.git / commitdiff