--- /dev/null
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 174E9431FB6\r
+ for <notmuch@notmuchmail.org>; Tue, 2 Sep 2014 13:22:55 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id H-d5P1e0EcAk for <notmuch@notmuchmail.org>;\r
+ Tue, 2 Sep 2014 13:22:47 -0700 (PDT)\r
+Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com\r
+ [209.85.212.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 7D1B4431FAF\r
+ for <notmuch@notmuchmail.org>; Tue, 2 Sep 2014 13:22:47 -0700 (PDT)\r
+Received: by mail-wi0-f172.google.com with SMTP id n3so15034708wiv.17\r
+ for <notmuch@notmuchmail.org>; Tue, 02 Sep 2014 13:22:44 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+ :user-agent:date:message-id:mime-version:content-type;\r
+ bh=Je4N5AHSKw1qdJdvezbJBqzWHgl/9fYGqaSM7BCZ2JM=;\r
+ b=ilq50w+pu1w3b10utn5h70vzY3935Mgr0diLb24fR1QkSZy0Dhp3VjJd1xkpJ3rPLi\r
+ BHo3z8hiCVGRDMiBoN0kOKcBS9xmd7tADmWl7ZovLVov++FD8CTYDjzY5izU0C/XK97j\r
+ vfFUs7xxkVYKuDN87y69eheOqGEdRFHOGUXy3TAa1PCxurMLaaB9lREGnRyqt6Su0zbx\r
+ CRdyaB5+BxH2unR8pJnORjPqdN7x4CnwC2hckulf0naU3Y82Lo06m2fdKJmH3RLjcg7p\r
+ UJw/0K/eyqO6rGLy+2kpBIkqfWgEuSsnimegw6paNuR8ZFgfX0UzLF2nFOOxjULEIzs/\r
+ Q2QA==\r
+X-Gm-Message-State:\r
+ ALoCoQnh63qRzygOVaDvRoWMNYl5fu7f/7g+ziJWF57E3+ZkzIOD3htACXv/SBiV99CvW/B9Wt1I\r
+X-Received: by 10.180.100.202 with SMTP id fa10mr24800810wib.32.1409689364746;\r
+ Tue, 02 Sep 2014 13:22:44 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c374-75.dhcp.inet.fi.\r
+ [88.195.116.75]) by mx.google.com with ESMTPSA id\r
+ am1sm11680220wjc.29.2014.09.02.13.22.43 for <multiple recipients>\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Tue, 02 Sep 2014 13:22:44 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: jump: sort-order bugfix\r
+In-Reply-To: <1409684164-28407-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1409661049-23417-1-git-send-email-markwalters1009@gmail.com>\r
+ <1409684164-28407-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.18.1+65~g9f0f30f (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 02 Sep 2014 23:22:42 +0300\r
+Message-ID: <87tx4pvkkt.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 02 Sep 2014 20:22:55 -0000\r
+\r
+On Tue, 02 Sep 2014, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> default-value needs its argument to be quoted.\r
+>\r
+> Slightly strangely default-value of 't or nil is 't or nil\r
+> respectively so the code\r
+>\r
+> (default-value notmuch-search-oldest-first)\r
+>\r
+> just gives the current value of notmuch-search-oldest-first rather\r
+> than intended default-value of this variable.\r
+>\r
+> The symptom is that if you are in a search buffer and use notmuch jump\r
+> to run a saved search which does not have an explicitly set sort order\r
+> then the sort order of the saved-search is inherited from the current\r
+> search buffer rather than being the default search order.\r
+>\r
+> Thanks to Jani for finding the bug.\r
+\r
+This fixes the issue, thanks for the patch.\r
+\r
+Jani.\r
+\r
+\r
+\r
+> ---\r
+>\r
+> This time with a fuller commit message.\r
+>\r
+> (Part of the reason I did not send more before is I had not checked\r
+> what the exact outcome of the buggy code was: it was obvious what the\r
+> code was intended to do, and that with the extra quote it\r
+> would do what it was intended to do.)\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+>\r
+>\r
+>\r
+>\r
+>\r
+> emacs/notmuch-jump.el | 2 +-\r
+> 1 file changed, 1 insertion(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el\r
+> index 5eb0949..0193f8c 100644\r
+> --- a/emacs/notmuch-jump.el\r
+> +++ b/emacs/notmuch-jump.el\r
+> @@ -51,7 +51,7 @@ (defun notmuch-jump-search ()\r
+> (case (plist-get saved-search :sort-order)\r
+> (newest-first nil)\r
+> (oldest-first t)\r
+> - (otherwise (default-value notmuch-search-oldest-first)))))\r
+> + (otherwise (default-value 'notmuch-search-oldest-first)))))\r
+> (push (list key name\r
+> `(lambda () (notmuch-search ',query ',oldest-first)))\r
+> action-map)))))\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff