2009-11-05 Marcus Brinkmann <marcus@g10code.de>

	* priv-io.h (IOSPAWN_FLAG_NOCLOSE): New flag.
	* w32-io.c (_gpgme_io_spawn): Implement this flag.
	* posix-io.c (_gpgme_io_spawn): Likewise.
	* w32-glib-io.c (_gpgme_io_spawn): Likewise.
	* assuan-support.c (my_spawn): Set this flag.

diff --git a/src/ChangeLog b/src/ChangeLog
index d5aebe3e9494e430adcf6ffe8088d5a98807447d..0ea3a1c349253f3a826cbe1dd6d54b1719552514 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,11 @@
 2009-11-05  Marcus Brinkmann  <marcus@g10code.de>
 
+       * priv-io.h (IOSPAWN_FLAG_NOCLOSE): New flag.
+       * w32-io.c (_gpgme_io_spawn): Implement this flag.
+       * posix-io.c (_gpgme_io_spawn): Likewise.
+       * w32-glib-io.c (_gpgme_io_spawn): Likewise.
+       * assuan-support.c (my_spawn): Set this flag.
+
        * decrypt.c (gpgme_op_decrypt_start): Fix use of debug macro.
        * decrypt-verify.c (gpgme_op_decrypt_verify_start): Likewise.
        * delete.c (gpgme_op_delete_start): Likewise.

diff --git a/src/assuan-support.c b/src/assuan-support.c
index b5d2548a1edd50fe56361f1d8c966ce7c5db6a1b..4646416f2ec1748027122a2c0145d5e7fb764ca3 100644 (file)
--- a/src/assuan-support.c
+++ b/src/assuan-support.c
@@ -152,7 +152,7 @@ my_spawn (assuan_context_t ctx, pid_t *r_pid, const char *name,
   fd_items[i].fd = -1;
   fd_items[i].dup_to = -1;
 
-  err = _gpgme_io_spawn (name, argv, 0, fd_items, r_pid);
+  err = _gpgme_io_spawn (name, argv, IOSPAWN_FLAG_NOCLOSE, fd_items, r_pid);
   if (! err)
     {
       i = 0;

diff --git a/src/posix-io.c b/src/posix-io.c
index 1025268e7ea6262cb1b70a7f602c0d2f8bc62032..b173f58e70de2c69ca9404acdf61ec130b2807da 100644 (file)
--- a/src/posix-io.c
+++ b/src/posix-io.c
@@ -454,7 +454,8 @@ _gpgme_io_spawn (const char *path, char *const argv[], unsigned int flags,
 
   for (i = 0; fd_list[i].fd != -1; i++)
     {
-      _gpgme_io_close (fd_list[i].fd);
+      if (! (flags & IOSPAWN_FLAG_NOCLOSE))
+       _gpgme_io_close (fd_list[i].fd);
       /* No handle translation.  */
       fd_list[i].peer_name = fd_list[i].fd;
     }

diff --git a/src/priv-io.h b/src/priv-io.h
index 4eb2e362ac57165e819254dfe07bfce733a4c693..a9fb02ae53068821d62d530037f9c826043642fa 100644 (file)
--- a/src/priv-io.h
+++ b/src/priv-io.h
@@ -68,6 +68,8 @@ int _gpgme_io_set_nonblocking (int fd);
 /* A flag to tell the spawn function to allow the child process to set
    the foreground window. */
 #define IOSPAWN_FLAG_ALLOW_SET_FG 1
+/* Don't close any child FDs.  */
+#define IOSPAWN_FLAG_NOCLOSE 2
 
 /* Spawn the executable PATH with ARGV as arguments.  After forking
    close all fds except for those in FD_LIST in the child, then

diff --git a/src/w32-glib-io.c b/src/w32-glib-io.c
index c1542cc0d75aec57c36b32ed08795b1049c2f066..17d60fc0b68a4fb9c0dc52c56d9aeeeba555e006 100644 (file)
--- a/src/w32-glib-io.c
+++ b/src/w32-glib-io.c
@@ -777,8 +777,11 @@ _gpgme_io_spawn (const char *path, char * const argv[], unsigned int flags,
     TRACE_LOG1 ("CloseHandle of process failed: ec=%d",
                (int) GetLastError ());
 
-  for (i = 0; fd_list[i].fd != -1; i++)
-    _gpgme_io_close (fd_list[i].fd);
+  if (! (flags & IOSPAWN_FLAG_NOCLOSE))
+    {
+      for (i = 0; fd_list[i].fd != -1; i++)
+       _gpgme_io_close (fd_list[i].fd);
+    }
 
   for (i = 0; fd_list[i].fd != -1; i++)
     if (fd_list[i].dup_to == -1)

diff --git a/src/w32-io.c b/src/w32-io.c
index f87db121ea7133993f92542327161d973f0c3f5b..e83aa0b9fce14ac1f80b8730e02260ce21ba7e76 100644 (file)
--- a/src/w32-io.c
+++ b/src/w32-io.c
@@ -1234,8 +1234,11 @@ _gpgme_io_spawn (const char *path, char *const argv[], unsigned int flags,
     TRACE_LOG1 ("CloseHandle of process failed: ec=%d",
                (int) GetLastError ());
 
-  for (i = 0; fd_list[i].fd != -1; i++)
-    _gpgme_io_close (fd_list[i].fd);
+  if (! (flags & IOSPAWN_FLAG_NOCLOSE))
+    {
+      for (i = 0; fd_list[i].fd != -1; i++)
+       _gpgme_io_close (fd_list[i].fd);
+    }
 
   for (i = 0; fd_list[i].fd != -1; i++)
     if (fd_list[i].dup_to == -1)