--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 3AB86431FC9\r
+ for <notmuch@notmuchmail.org>; Wed, 21 Jan 2015 01:38:44 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.438\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
+ tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id zmTb555NAIYi for <notmuch@notmuchmail.org>;\r
+ Wed, 21 Jan 2015 01:38:41 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id D3AD1431FBC\r
+ for <notmuch@notmuchmail.org>; Wed, 21 Jan 2015 01:38:40 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id A22A61000E0;\r
+ Wed, 21 Jan 2015 11:38:19 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org,\r
+ Jani Nikula <jani@nikula.org>\r
+Subject: Re: [DRAFT PATCH v2] modified notmuch-emacs-mua v2\r
+In-Reply-To: <87ppa9xor8.fsf@maritornes.cs.unb.ca>\r
+References: <1421598115-4889-1-git-send-email-david@tethera.net>\r
+ <1421776424-24304-1-git-send-email-tomi.ollila@iki.fi>\r
+ <87ppa9xor8.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.19+29~g7367d27 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 21 Jan 2015 11:38:19 +0200\r
+Message-ID: <m2y4owwk1g.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 21 Jan 2015 09:38:44 -0000\r
+\r
+On Tue, Jan 20 2015, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> This is second draft patch of (first being)\r
+>>\r
+>> id:1405026779-29966-1-git-send-email-tomi.ollila@iki.fi\r
+>>\r
+>> I saw potential problem with only supporting emacsclient(1) in\r
+>> the version David sent:\r
+>> id:1421598115-4889-1-git-send-email-david@tethera.net\r
+>>\r
+>> (no emacs server running and no tty -- new X client not started)\r
+>>\r
+>\r
+> I don't understand what use case is failing for you. I think I tested\r
+> all 4 combinations of DISPLAY set and unset and emacs server running and\r
+> not running. Do you somehow want to run the notmuch-emacs-mua script\r
+> from a process not attached to a terminal (from cron?).\r
+\r
+It seems that you have done good testing and I just failed to test using\r
+exactly the same options you have:\r
+\r
+emacsclient -c -a '' .zshrc\r
+\r
+Works as one'd expect to work successfully in all cases, DISPLAY set/unset\r
+and emacs-server running or not (now deleting 6 lines of text below that\r
+was based on wrong assumtions...)\r
+\r
+// 6 lines of text deleted ... :) //\r
+\r
+So, the question goes into deciding whether the magic of starting emacs\r
+server to the user if it is not running -- something that many users would\r
+not anticipate/desire (I am one of those)...\r
+\r
+Running emacs via emacsclient has subtle differences to just running emacs\r
+the "regular" way -- while testing I just had problems exiting the\r
+emacsclient session without exiting the whole emacs -- I exited the whole\r
+emacs and next time paid attention to minibuffer message saying c-x 5 0\r
+exits the session...\r
+Now that I got the tests work as David would have expected me to do those,\r
+the frame emacs started looked different that my emacs frames have when\r
+starting "normally" -- there was extra toolbar in the frame (I have\r
+inhibited all menu and toolbars in my normal setup). Just that it behaves\r
+differently is suspicious.\r
+\r
+Therefore, IMO it is clearer to run "regular" emacs unless user is\r
+explicitly running emacs-server and can anticipate the behaviour\r
+differences when running emacsclient there.\r
+\r
+\r
+>> In case emacsclient(1) is used and no --no-window-system, '-c' arg is\r
+>> given to emacsclient like in the version David sent.\r
+>>\r
+>> (this means that if emacs is not running on X, user may get this message:\r
+>> "emacsclient: could not get terminal name" -- we need to document user\r
+>> to give -nw (--no-window-system) option then)\r
+>\r
+> As I wrote above, I'm missing what the tradeoff is. The version I sent\r
+> works fine (at least for me) in the case where DISPLAY is not set and\r
+> --no-window-system is not given (i.e. it's implied if DISPLAY is not\r
+> set).\r
+\r
+Ok, my tests failed colossally here. Sorry. First, I forgot to have\r
+-a '' there (for comparison) and secondly I closed stdout before\r
+running emacsclient (bug in the script). \r
+\r
+That's what you get after almost 3 hours of vigorous hacking there; the\r
+manual test coverage is probably not the best possible...\r
+\r
+>\r
+> d\r
+\r
+Tomi\r
projects / notmuch-archives.git / commitdiff