Re: [notmuch] [PATCH] Change From and Bcc when creating reply draft buffer

diff --git a/ea/fe8d08ffa1db3b8d633d5e4acffe479c498725 b/ea/fe8d08ffa1db3b8d633d5e4acffe479c498725
new file mode 100644 (file)
index 0000000..b0ef255
--- /dev/null
+++ b/ea/fe8d08ffa1db3b8d633d5e4acffe479c498725
@@ -0,0 +1,94 @@
+Return-Path: <sojkam1@fel.cvut.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6A14A49F192\r
+       for <notmuch@notmuchmail.org>; Thu, 11 Mar 2010 05:00:34 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.514\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.514 tagged_above=-999 required=5\r
+       tests=[AWL=-0.404, BAYES_05=-1.11] autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id OqFZHfDTmtRj for <notmuch@notmuchmail.org>;\r
+       Thu, 11 Mar 2010 05:00:32 -0800 (PST)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 774414916B2\r
+       for <notmuch@notmuchmail.org>; Thu, 11 Mar 2010 05:00:32 -0800 (PST)\r
+Received: from localhost (unknown [192.168.200.4])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id D3BC619F35F8;\r
+       Thu, 11 Mar 2010 14:00:13 +0100 (CET)\r
+X-Virus-Scanned: IMAP AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+       by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,\r
+       port 10044)\r
+       with ESMTP id n2-OyK7Yuny7; Thu, 11 Mar 2010 14:00:08 +0100 (CET)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id AEB6719F35EE;\r
+       Thu, 11 Mar 2010 14:00:08 +0100 (CET)\r
+Received: from steelpick.localdomain (k335-30.felk.cvut.cz [147.32.86.30])\r
+       (Authenticated sender: sojkam1)\r
+       by imap.feld.cvut.cz (Postfix) with ESMTPSA id 9E8B3FA003;\r
+       Thu, 11 Mar 2010 14:00:08 +0100 (CET)\r
+Received: from wsh by steelpick.localdomain with local (Exim 4.71)\r
+       (envelope-from <sojkam1@fel.cvut.cz>)\r
+       id 1Nphzk-00074j-Fv; Thu, 11 Mar 2010 14:00:08 +0100\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: James Vasile <james@hackervisions.org>, notmuch@notmuchmail.org\r
+In-Reply-To: <87aauhp9kk.fsf@hackervisions.org>\r
+References: <87aauhp9kk.fsf@hackervisions.org>\r
+Date: Thu, 11 Mar 2010 14:00:08 +0100\r
+Message-ID: <87pr3bm2sn.fsf@steelpick.localdomain>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Subject: Re: [notmuch] [PATCH] Change From and Bcc when creating reply draft\r
+       buffer\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 11 Mar 2010 13:00:34 -0000\r
+\r
+Hi James,\r
+\r
+On Tue, 09 Mar 2010, James Vasile wrote:\r
+> When notmuch creates a reply buffer, it guesses the From and Bcc\r
+> addresses.  The client is in a better position to guess these, and this\r
+> patch adjusts notmuch-reply accordingly.\r
+> \r
+> diff --git a/notmuch.el b/notmuch.el\r
+> index ab56f48..07f957e 100644\r
+> --- a/notmuch.el\r
+> +++ b/notmuch.el\r
+> @@ -436,10 +436,20 @@ buffer."\r
+>    (message "Done"))\r
+>  \r
+>  (defun notmuch-reply (query-string)\r
+> +  "Prepare a reply draft buffer.\r
+> +\r
+> +Have notmuch create a reply buffer, then adjust the from and bcc\r
+> +headers to match our current user-full-name and\r
+> +user-mail-address."\r
+>    (switch-to-buffer (generate-new-buffer "notmuch-draft"))\r
+>    (call-process notmuch-command nil t nil "reply" query-string)\r
+>    (message-insert-signature)\r
+>    (goto-char (point-min))\r
+> +  (kill-line)\r
+> +  (insert (format "From: %s <%s>" user-full-name user-mail-address))\r
+\r
+Notmuch reply contains From: address which is based on the addresses in\r
+.notmuch-config and the replied message. When you use multiple addresses\r
+(e.g. home and work address), notmuch puts there the one used in the\r
+replied message. It seems that your patch would break this feature.\r
+\r
+-Michal\r