Re: [PATCH 1/2] emacs: add defsubst notmuch-address--message-insinuated

diff --git a/a5/117b0bf6fb7291072eb66695ecc71a8d8548a1 b/a5/117b0bf6fb7291072eb66695ecc71a8d8548a1
new file mode 100644 (file)
index 0000000..4eb2aca
--- /dev/null
+++ b/a5/117b0bf6fb7291072eb66695ecc71a8d8548a1
@@ -0,0 +1,74 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 071796DE17EB\r
+ for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 08:03:35 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.203\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.203 tagged_above=-999 required=5 tests=[AWL=-0.193,\r
+  SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id z_I5zmznAd8Y for <notmuch@notmuchmail.org>;\r
+ Sun, 30 Aug 2015 08:03:33 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 007406DE17E1\r
+ for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 08:03:32 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 0713E10005A;\r
+ Sun, 30 Aug 2015 18:02:07 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] emacs: add defsubst\r
+ notmuch-address--message-insinuated\r
+In-Reply-To: <87y4gtrmdr.fsf@maritornes.cs.unb.ca>\r
+References: <1440619626-18768-1-git-send-email-tomi.ollila@iki.fi>\r
+ <87y4gtrmdr.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 30 Aug 2015 18:02:06 +0300\r
+Message-ID: <m27foc251t.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 30 Aug 2015 15:03:35 -0000\r
+\r
+On Sun, Aug 30 2015, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> +(defsubst notmuch-address--message-insinuated ()\r
+>> +  (memq notmuch-address-message-alist-member message-completion-alist))\r
+>> +\r
+>\r
+> Is there some advantage to defsubst other than (maybe?) performance?  It\r
+> just seems like one more construct for people to get up to speed with\r
+> the codebase.\r
+\r
+No advantage. The reason for defsubst may originally be that I did it for\r
+least execution chance -- and iirc I was reading some (gnus?) code that\r
+had quite a few defsubsts which infected my coding. Now that I checked\r
+there is no (other) defsubsts code in notmuch-emacs... so that can be\r
+just be changed to `defun' to be consistent in that sense.\r
+\r
+>\r
+> d\r
+\r
+Tomi\r