Re: [PATCH 3/3] cli: fix clang build warnings

diff --git a/d5/17ad773486ab966f776b0350f06af0f4bb7854 b/d5/17ad773486ab966f776b0350f06af0f4bb7854
new file mode 100644 (file)
index 0000000..7cc0111
--- /dev/null
+++ b/d5/17ad773486ab966f776b0350f06af0f4bb7854
@@ -0,0 +1,103 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 66108431FDF\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Feb 2015 11:20:13 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.438\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nRx30HIWUmD8 for <notmuch@notmuchmail.org>;\r
+       Mon, 23 Feb 2015 11:20:10 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 271CE431FDE\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Feb 2015 11:20:10 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id F291410019F;\r
+       Mon, 23 Feb 2015 21:11:32 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/3] cli: fix clang build warnings\r
+In-Reply-To: <1424710576-30468-3-git-send-email-jani@nikula.org>\r
+References: <1424710576-30468-1-git-send-email-jani@nikula.org>\r
+       <1424710576-30468-3-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.19+53~gb45d2f9 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 23 Feb 2015 21:11:32 +0200\r
+Message-ID: <m2twycmoij.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 23 Feb 2015 19:20:13 -0000\r
+\r
+On Mon, Feb 23 2015, Jani Nikula <jani@nikula.org> wrote:\r
+\r
+> Fix the following warning produced by clang 3.5.0:\r
+>\r
+> notmuch-search.c:730:25: warning: initializing 'void *' with an\r
+> expression of type 'const notmuch_opt_desc_t (*)[4]' discards\r
+> qualifiers [-Wincompatible-pointer-types-discards-qualifiers]\r
+>         { NOTMUCH_OPT_INHERIT, &common_options, NULL, 0, 0 },\r
+>                                ^~~~~~~~~~~~~~~\r
+> 1 warning generated.\r
+>\r
+> ---\r
+>\r
+> I'm not really happy with this one. An alternative would be to drop\r
+> const from common_options, but I'm not happy with that either. And I'm\r
+> not happy with the warning. :(\r
+\r
+This looks tolerable to be and the whole series good. tests pass.\r
+\r
+> ---\r
+>  notmuch-search.c | 4 ++--\r
+>  1 file changed, 2 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/notmuch-search.c b/notmuch-search.c\r
+> index 14b9f01c5ad1..a591d45b4c39 100644\r
+> --- a/notmuch-search.c\r
+> +++ b/notmuch-search.c\r
+> @@ -671,7 +671,7 @@ notmuch_search_command (notmuch_config_t *config, int argc, char *argv[])\r
+>      { NOTMUCH_OPT_INT, &ctx->offset, "offset", 'O', 0 },\r
+>      { NOTMUCH_OPT_INT, &ctx->limit, "limit", 'L', 0  },\r
+>      { NOTMUCH_OPT_INT, &ctx->dupe, "duplicate", 'D', 0  },\r
+> -    { NOTMUCH_OPT_INHERIT, &common_options, NULL, 0, 0 },\r
+> +    { NOTMUCH_OPT_INHERIT, (void *) &common_options, NULL, 0, 0 },\r
+>      { 0, 0, 0, 0, 0 }\r
+>      };\r
+>  \r
+> @@ -727,7 +727,7 @@ notmuch_address_command (notmuch_config_t *config, int argc, char *argv[])\r
+>        (notmuch_keyword_t []){ { "true", NOTMUCH_EXCLUDE_TRUE },\r
+>                                { "false", NOTMUCH_EXCLUDE_FALSE },\r
+>                                { 0, 0 } } },\r
+> -    { NOTMUCH_OPT_INHERIT, &common_options, NULL, 0, 0 },\r
+> +    { NOTMUCH_OPT_INHERIT, (void *) &common_options, NULL, 0, 0 },\r
+>      { 0, 0, 0, 0, 0 }\r
+>      };\r
+>  \r
+> -- \r
+> 2.1.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r