Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax

diff --git a/60/138e629e9769cf408bf29cf158f3ff5759ce3a b/60/138e629e9769cf408bf29cf158f3ff5759ce3a
new file mode 100644 (file)
index 0000000..9a4f45c
--- /dev/null
+++ b/60/138e629e9769cf408bf29cf158f3ff5759ce3a
@@ -0,0 +1,90 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EE1A2431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  3 May 2013 17:54:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id hDTuBELEsqJV for <notmuch@notmuchmail.org>;\r
+       Fri,  3 May 2013 17:54:41 -0700 (PDT)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id DDE4A431FAF\r
+       for <notmuch@notmuchmail.org>; Fri,  3 May 2013 17:54:40 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r440se3Y032767;\r
+       Fri, 3 May 2013 21:54:40 -0300\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UYQkF-0005UT-Hg; Fri, 03 May 2013 21:54:39 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UYQk9-0005K7-Uk; Fri, 03 May 2013 21:54:29 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: "Alexey I. Froloff" <raorn@raorn.name>\r
+Subject: Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax\r
+In-Reply-To: <20130430095213.GA2861@raorn.name>\r
+References: <20130409083010.GA27675@raorn.name>\r
+       <1365549369-12776-1-git-send-email-raorn@raorn.name>\r
+       <87vc74vn2n.fsf@zancas.localnet> <20130430095213.GA2861@raorn.name>\r
+User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 03 May 2013 21:54:29 -0300\r
+Message-ID: <871u9nva2i.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 May 2013 00:54:46 -0000\r
+\r
+"Alexey I. Froloff" <raorn@raorn.name> writes:\r
+\r
+>\r
+>> > +    void *local = talloc_new (message);\r
+>>       we should handle ENOMEM here, I think.\r
+> There are 16 talloc_new() calls and ENOMEM is not handled\r
+> anywhere.\r
+\r
+This makes me a bit sad but I agree it's not your fault ;).\r
+>\r
+>> > +    /* _notmuch_message_add_term() may return\r
+>> > +     * NOTMUCH_PRIVATE_STATUS_TERM_TOO_LONG here.  We can't fix it, but\r
+>> > +     * this is not a reason to exit with error... */\r
+>> > +    if (_notmuch_message_add_term (message, "list", list_id))\r
+>> > + fprintf (stderr, "Warning: Not indexing List-Id: <%s>\n", list_id);\r
+>> This should say why the indexing failed.\r
+> There should be strerror-like function, then can give description\r
+> for a given status code.\r
+\r
+There is, but only for the public status values. \r
+\r
+I guess the most correct thing would be to check for equality with\r
+NOTMUCH_PRIVATE_STATUS_TERM_TOO_LONG, print an appropriate error message\r
+if so, and otherwise use\r
+notmuch_status_to_string(COERCE_STATUS(private_status))\r
+\r
+d\r
+\r