Re: [PATCH] emacs: bugfix attachment content-type as mime-type handling

diff --git a/e0/9f6d101f87ddfbe117dea002caa71d1425f9f3 b/e0/9f6d101f87ddfbe117dea002caa71d1425f9f3
new file mode 100644 (file)
index 0000000..873e319
--- /dev/null
+++ b/e0/9f6d101f87ddfbe117dea002caa71d1425f9f3
@@ -0,0 +1,96 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C96EE431FC0\r
+       for <notmuch@notmuchmail.org>; Tue, 30 Jul 2013 19:25:44 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 7JM0hC0URg2T for <notmuch@notmuchmail.org>;\r
+       Tue, 30 Jul 2013 19:25:37 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu\r
+       [18.7.68.37])\r
+       by olra.theworths.org (Postfix) with ESMTP id 32CCE431FBF\r
+       for <notmuch@notmuchmail.org>; Tue, 30 Jul 2013 19:25:37 -0700 (PDT)\r
+X-AuditID: 12074425-b7f0c8e000000953-32-51f8759f3a1b\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+       by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 2E.CB.02387.F9578F15; Tue, 30 Jul 2013 22:25:35 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r6V2PYCu031338; \r
+       Tue, 30 Jul 2013 22:25:35 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r6V2PUWG009720\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Tue, 30 Jul 2013 22:25:33 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1V4M6T-0006p4-FS; Tue, 30 Jul 2013 22:25:29 -0400\r
+Date: Tue, 30 Jul 2013 22:25:29 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH] emacs: bugfix attachment content-type as mime-type\r
+       handling\r
+Message-ID: <20130731022529.GU2214@mit.edu>\r
+References: <87li4om623.fsf@qmul.ac.uk>\r
+       <1375200900-5650-1-git-send-email-markwalters1009@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1375200900-5650-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFupnleLIzCtJLcpLzFFi42IR4hTV1p1f+iPQ4M02WYvVc3ksrt+cyezA\r
+       5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZRzq6mIpuMJesX3TBMYGxulsXYycHBICJhL7\r
+       13axQthiEhfurQeKc3EICexjlDhxYh0zhLORUeL5mg5GCOc0k8S61q1QmSWMEqvub2AB6WcR\r
+       UJV4c6MXzGYT0JDYtn85I4gtIqAjcfvQAnYQm1lAWuLb72YmEFtYIEji+4TjzCA2r4C2xJwn\r
+       vWA3CQmkSexbv5YJIi4ocXLmExaIXi2JG/9eAsU5wOYs/8cBEuYU8JQ48u03WImogIrElJPb\r
+       2CYwCs1C0j0LSfcshO4FjMyrGGVTcqt0cxMzc4pTk3WLkxPz8lKLdC30cjNL9FJTSjcxgsKa\r
+       3UV1B+OEQ0qHGAU4GJV4eB0ufA8UYk0sK67MPcQoycGkJMrLW/IjUIgvKT+lMiOxOCO+qDQn\r
+       tfgQowQHs5IIr3wQUI43JbGyKrUoHyYlzcGiJM77/OnZQCGB9MSS1OzU1ILUIpisDAeHkgSv\r
+       ODB+hQSLUtNTK9Iyc0oQ0kwcnCDDeYCGvwdZzFtckJhbnJkOkT/FqMsx+eyW94xCLHn5ealS\r
+       4ry/QYoEQIoySvPg5sDS0StGcaC3hHmVQdbxAFMZ3KRXQEuYgJbsVvkGsqQkESEl1cAo/Gbf\r
+       Kn6t2rBp3JcYT1fpG/Ok3fjCvFviW/u0M7ETg2cxTrgs8q5yN7+/XdDxDQr8T5j+Hu9Z+uXj\r
+       2rZjJQ7Hbj2Xlt3ObbeXU3SpdrL61dBmhXPHcnWZbJKWKwhrl/1ZPlG9eVN+a8C+2S1fd3w6\r
+       yzHNtXBK2JxHMTeLpzsX3BP5vVX33lNrJZbijERDLeai4kQAEUx6BCIDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 31 Jul 2013 02:25:44 -0000\r
+\r
+Quoth Mark Walters on Jul 30 at  5:15 pm:\r
+> Notmuch puts attachments in as declared content-type except when the\r
+> content-type is application/octet-stream it tries to guess the type\r
+> from the filename/extension. This means that viewing a pdf (for\r
+> example) which is sent as application/octet-strem invokes the pdf\r
+> viewer rather than just offering to save the part.\r
+> \r
+> Recent changes to the attachment handling (commit 1546387d) changed\r
+> (broke) this. This patch stores the calculated mime-type with the part\r
+> and changes the attachment part handlers can use it instead.\r
+> ---\r
+> This seems to fix the bug for me. I am not sure I like the naming\r
+> (mime-type/content-type). Maybe it would be better to be explicit with\r
+> something like calculated-content-type but probably that should be a\r
+> more wholesale renaming.\r
+\r
+Code LGTM, though I agree the naming could be better.  It would be\r
+nice to have a test for this so we don't regress again in the future.\r