--- /dev/null
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 7E4C0431FC0\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Dec 2014 13:04:26 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id OVOPu+CDdQ8A for <notmuch@notmuchmail.org>;\r
+ Sat, 13 Dec 2014 13:04:23 -0800 (PST)\r
+Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com\r
+ [74.125.82.42]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client\r
+ certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
+ 1A6F4431FB6 for <notmuch@notmuchmail.org>; Sat, 13 Dec 2014 13:04:23 -0800\r
+ (PST)\r
+Received: by mail-wg0-f42.google.com with SMTP id z12so11700640wgg.1\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Dec 2014 13:04:22 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:from:to:cc:subject:in-reply-to:references\r
+ :user-agent:date:message-id:mime-version:content-type\r
+ :content-transfer-encoding;\r
+ bh=HdS/IysqM1EiMVrJYa9uceX/2fJMEnTiyhBqB5fVwOw=;\r
+ b=InFBznqRnLeHPEngVWBU3USkERqNiNEQPXDwxCTjdSHVlAQi/BqgHWFKdM4PA4d6OT\r
+ 2cWVqDr7poTT4DR6TZR7LilVZMIuy6mPkMVXbRVbux2E6IznETPfDtoPVK+av3CoaqXo\r
+ 9UgQAO4bvLpedluhRb5Ts9JDDBjQVwS6XEnU4R/r0or8vU+qZy/9VJsLsnzY2/sJ0Ou6\r
+ 8TjU7kKQZ5vssZ3uWxT6AjJwV14/hBX1JhTnQZPgTvyqU38i7RruPOIniLMzbAFUPeWD\r
+ NLBzmH9NBn4yyCmZvmwluptstE1sqXiuNnrm9eAnaVf2fh1Q5Ll3FZJo2/1okCMQdy6f\r
+ Qc6A==\r
+X-Gm-Message-State:\r
+ ALoCoQnM4U9nV5B5+9uV4qj5CxfVPZBSqRpSTEFgLNLuvGcfhy8hlLC6+S2+iHZ7AW8ro/hBF47b\r
+X-Received: by 10.194.8.232 with SMTP id u8mr12506743wja.47.1418504661883;\r
+ Sat, 13 Dec 2014 13:04:21 -0800 (PST)\r
+Received: from localhost (dsl-hkibrasgw2-58c37d-174.dhcp.inet.fi.\r
+ [88.195.125.174])\r
+ by mx.google.com with ESMTPSA id bj3sm6943750wib.3.2014.12.13.13.04.20\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Sat, 13 Dec 2014 13:04:21 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: =?utf-8?Q?=C5=81ukasz?= Stelmach <stlman@poczta.fm>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: do not change users' mail agent configuration\r
+In-Reply-To: <1418410466-26604-1-git-send-email-stlman@poczta.fm>\r
+References: <1418410466-26604-1-git-send-email-stlman@poczta.fm>\r
+User-Agent: Notmuch/0.19+3~g7585e8c (http://notmuchmail.org) Emacs/24.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 13 Dec 2014 23:04:26 +0200\r
+Message-ID: <87k31vqn1h.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+Cc: =?utf-8?Q?=C5=81ukasz?= Stelmach <stlman@poczta.fm>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 13 Dec 2014 21:04:26 -0000\r
+\r
+On Fri, 12 Dec 2014, =C5=81ukasz Stelmach <stlman@poczta.fm> wrote:\r
+> `mail-user-agent' is defined with defcustom and may be customised\r
+> by users. It should not be set to arbitrary values in modules.\r
+\r
+Point taken.\r
+\r
+> To make use of that configuration value call `compose-mail' which\r
+> starts user's preferred mail composition package as selected with\r
+> the variable `mail-user-agent' instead of notmuch's hardcoded\r
+> `message-mail'.\r
+\r
+So your proposed change is that `notmuch-mua-mail` should start\r
+whichever mua the user has configured in `mail-user-agent` instead of\r
+the notmuch mail composition window, as described in the function\r
+documentation? I don't think I like that either.\r
+\r
+Maybe we should let bind `mail-user-agent` instead?\r
+\r
+> ---\r
+> NEWS | 10 ++++++++++\r
+> emacs/notmuch-mua.el | 2 +-\r
+> emacs/notmuch.el | 2 --\r
+> 3 files changed, 11 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/NEWS b/NEWS\r
+> index 44e8d05..cf5b3c3 100644\r
+> --- a/NEWS\r
+> +++ b/NEWS\r
+> @@ -64,6 +64,16 @@ Added `notmuch address` subcommand\r
+> Emacs Interface\r
+> ---------------\r
+>=20=20\r
+> +Fixed `mail-user-agent` handling\r
+> +\r
+> + The value of the mail-user-agent variable is not forcibly set to\r
+> + `notmuch-user-agent`, regardles of how a user has customised it,\r
+> + everytime notmuch.el is loaded. This way, someone who used for example\r
+> + Gnus has her MUA and notmuch just as a search engine, doesn't have her\r
+> + configuration broken everytime notmuch.el is loaded. The user can now\r
+> + use her favourite mail composing package when replying messages in\r
+> + notmuch too.\r
+\r
+I understand you're annoyed at the current behaviour, but please don't\r
+pour that annoyance into notmuch NEWS. Thank you.\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+> +\r
+> Use the `j` key to access saved searches from anywhere in notmuch\r
+>=20=20\r
+> `j` is now globally bound to `notmuch-jump`, which provides fast,\r
+> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+> index 2c58886..f02c7b5 100644\r
+> --- a/emacs/notmuch-mua.el\r
+> +++ b/emacs/notmuch-mua.el\r
+> @@ -263,7 +263,7 @@ OTHER-ARGS are passed through to `message-mail'."\r
+> (push (cons 'From (concat\r
+> (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) oth=\r
+er-headers))\r
+>=20=20\r
+> - (apply #'message-mail to subject other-headers other-args)\r
+> + (apply #'compose-mail to subject other-headers other-args)\r
+> (message-sort-headers)\r
+> (message-hide-headers)\r
+> (set-buffer-modified-p nil)\r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index 218486a..80cab57 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -1037,8 +1037,6 @@ notmuch buffers exist, run `notmuch'."\r
+> (switch-to-buffer first))\r
+> (notmuch))))\r
+>=20=20\r
+> -(setq mail-user-agent 'notmuch-user-agent)\r
+> -\r
+> (provide 'notmuch)\r
+>=20=20\r
+> ;; After provide to avoid loops if notmuch was require'd via notmuch-ini=\r
+t-file.\r
+> --=20\r
+> 2.0.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff