Re: [PATCH 00/11] Add ghost messages and fix thread linking

diff --git a/f7/8f950046256fcb4cba80eee1588b052320424d b/f7/8f950046256fcb4cba80eee1588b052320424d
new file mode 100644 (file)
index 0000000..2359baf
--- /dev/null
+++ b/f7/8f950046256fcb4cba80eee1588b052320424d
@@ -0,0 +1,89 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 91F0A431FC3\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Oct 2014 01:31:11 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id VkZ0Vr+ZbOC7 for <notmuch@notmuchmail.org>;\r
+       Sat,  4 Oct 2014 01:31:06 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id AC2F9431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Oct 2014 01:31:06 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 2EB6D10008D;\r
+       Sat,  4 Oct 2014 11:30:49 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <aclements@csail.mit.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 00/11] Add ghost messages and fix thread linking\r
+In-Reply-To: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
+References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
+User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 04 Oct 2014 11:30:48 +0300\r
+Message-ID: <m2oatsz16v.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 Oct 2014 08:31:11 -0000\r
+\r
+On Fri, Oct 03 2014, Austin Clements <aclements@csail.mit.edu> wrote:\r
+\r
+> This series modifies our database representation of messages that have\r
+> been referenced by other messages, but for which we don't have the\r
+> message itself.  Currently, we store this information as Xapian\r
+> metadata, but this has several downsides for performance and\r
+> complexity and results in hard-to-fix thread linking bugs.  This patch\r
+> series implements "ghost messages", which replace this Xapian metadata\r
+> with Xapian documents that look and act very much like regular message\r
+> documents, but simply have no content.  This simplifies and speeds up\r
+> our thread linking algorithm and fixes the currently broken thread\r
+> linking test.\r
+>\r
+> Ghost messages also open up interesting future possibilities, such as\r
+> "pre-seeding" tags for messages that are not yet indexed.  This could\r
+> be used to make notmuch insert simpler and more robust, as part of tag\r
+> synchronization, and to improve nmbug's behavior when tags arrive\r
+> before messages.\r
+\r
+The code looks OK to me -- there are IMO some strange things but those\r
+don't change the status quo -- I did look a little past the diffs into\r
+the code to understand something...\r
+\r
+I am now having these patches applied to my 'home' notmuch and haven't yet\r
+seen anything strange there. In this setup I have 27 emails missing that\r
+nmbug expects there to be -- let's see if I can get ghost messages there.\r
+\r
+... and tests pass, ran while writing the above part...\r
+\r
+I'll put these in use next week on one of my 'work' notmuch. There I have\r
+seen a problem that while I am on one thread, \r
+`notmuch-poll-and-refresh-buffer' picks new mail but suddenly this thread\r
+now has changed it's thread id :O -- making the search buffer go blank.\r
+I'll see whether it still happens with these (may be totally unrelated)\r
+and perhaps investigate further...\r
+\r
+\r
+Tomi\r
+\r