Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show...

diff --git a/e2/677a616f1563d918a0ab8399cb038329f53252 b/e2/677a616f1563d918a0ab8399cb038329f53252
new file mode 100644 (file)
index 0000000..5bc3065
--- /dev/null
+++ b/e2/677a616f1563d918a0ab8399cb038329f53252
@@ -0,0 +1,113 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B91CF429E2A\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Jun 2011 07:24:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id QiSphQkcrgsU for <notmuch@notmuchmail.org>;\r
+       Wed, 15 Jun 2011 07:24:45 -0700 (PDT)\r
+Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com\r
+       [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E1518429E26\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Jun 2011 07:24:44 -0700 (PDT)\r
+Received: by fxm8 with SMTP id 8so473561fxm.26\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Jun 2011 07:24:43 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=domainkey-signature:from:to:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=wPjpw5Too71dlKQ+IKKSYOFu6W0dtRBD9u5U8b/yYz8=;\r
+       b=NejOHVkTONpnV/Gekltd/d6AcSBGX0mWpKgSaNv1jO1VwZoITeX2MEP2IIFJpplz4Y\r
+       Oi5KjtEiWqmERzQfcUtrq9HEjIaE4ZFYXlcpHEAEZdnytAOZ+ttKrSHpjUNb/c34He/f\r
+       Yy31H3hhIm2BgF4AxhIRfJj1Fu9bAnPGUneSs=\r
+DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       b=j2Z4Zy9YcMT3SqybFihfxRI1OHrWboQCo8SVUYhCINQDGHpHc9UFGSJr/0avk5QUJc\r
+       j8B+5Zwh+V6ZGynEmWC4wnGbe7xFioKXAOnAcRLo8TJYcP8/aAmVQ7Bq0JxytZOnCcBX\r
+       rasiq7PhZUa2YTUkQLdyUZh3zc/MwOVsWM2J8=\r
+Received: by 10.223.76.129 with SMTP id c1mr664989fak.107.1308147883424;\r
+       Wed, 15 Jun 2011 07:24:43 -0700 (PDT)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id n13sm247785fab.46.2011.06.15.07.24.41\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 15 Jun 2011 07:24:42 -0700 (PDT)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown\r
+       in notmuch-show view.\r
+In-Reply-To: <87sjrbkx3j.fsf@yoom.home.cworth.org>\r
+References: <1306361416-5019-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1306361416-5019-4-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87oc2qa07g.fsf@yoom.home.cworth.org> <87k4depfyj.fsf@gmail.com>\r
+       <87lixu9z5b.fsf@yoom.home.cworth.org> <87hb8ipeb0.fsf@gmail.com>\r
+       <87ipsy9sue.fsf@yoom.home.cworth.org> <87d3j5pxk5.fsf@gmail.com>\r
+       <87k4ddcfnx.fsf@yoom.home.cworth.org> <877h9dp29t.fsf@gmail.com>\r
+       <87sjrbkx3j.fsf@yoom.home.cworth.org>\r
+User-Agent: Notmuch/0.5-237-gf6d8cdb (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 15 Jun 2011 18:25:14 +0400\r
+Message-ID: <8739jbqiid.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 15 Jun 2011 14:24:46 -0000\r
+\r
+On Wed, 15 Jun 2011 07:06:40 -0700, Carl Worth <cworth@cworth.org> wrote:\r
+> On Fri, 27 May 2011 01:42:22 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > I have just send two more patches to this thread.  One with new tests.\r
+> > Another with a workaround for the bug.  The workaround should not break\r
+> > anything since it affects only notmuch-show mode.\r
+> \r
+> Thanks!\r
+> \r
+> I love committing tests that demonstrate broken code before committing\r
+> fixes. As it happened here, I committed these two new patches thinking I\r
+> had previously committed the earlier patches in the series. Fortunately,\r
+> the failure of the test pointed out that I was missing the actual fix.\r
+> \r
+\r
+I know you prefer tests to go before patches and I agree with that.  But\r
+most of the time I do tests after coding.  I do not know an easy way to\r
+reorder patches in git.  (Also I do not know how to amend an old patch,\r
+wish more darcs features in git.)  Hopefully it is not a big trouble for\r
+you to reorder the patches when applying.\r
+\r
+> I also really like the workaround to avoid regressing functionality\r
+> because of an emacs bug.\r
+> \r
+\r
+indeed\r
+\r
+> Well done, Dmitry. I've now pushed out everything in this series.\r
+> \r
+\r
+Thanks.\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+> -Carl\r
+> \r
+> -- \r
+> carl.d.worth@intel.com\r