[PATCH] lib: fix definition of LIBNOTMUCH_CHECK_VERSION
authorDavid Bremner <david@tethera.net>
Mon, 6 Jun 2016 14:58:15 +0000 (11:58 +2100)
committerW. Trevor King <wking@tremily.us>
Sat, 20 Aug 2016 23:22:00 +0000 (16:22 -0700)
66/abf63284a183c205f17bb5b1820647e4b2d7f9 [new file with mode: 0644]

diff --git a/66/abf63284a183c205f17bb5b1820647e4b2d7f9 b/66/abf63284a183c205f17bb5b1820647e4b2d7f9
new file mode 100644 (file)
index 0000000..ffeae1d
--- /dev/null
@@ -0,0 +1,78 @@
+Return-Path: <bremner@tesseract.cs.unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 7952D6DE01C2\r
+ for <notmuch@notmuchmail.org>; Mon,  6 Jun 2016 08:34:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.006\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.006 tagged_above=-999 required=5\r
+ tests=[AWL=-0.007, HEADER_FROM_DIFFERENT_DOMAINS=0.001]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id jdwItI-Oggen for <notmuch@notmuchmail.org>;\r
+ Mon,  6 Jun 2016 08:33:57 -0700 (PDT)\r
+X-Greylist: delayed 2135 seconds by postgrey-1.35 at arlo;\r
+ Mon, 06 Jun 2016 08:33:57 PDT\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 54DE86DE00DA\r
+ for <notmuch@notmuchmail.org>; Mon,  6 Jun 2016 08:33:57 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <bremner@tesseract.cs.unb.ca>)\r
+ id 1b9vyi-0000Di-K2; Mon, 06 Jun 2016 10:58:08 -0400\r
+Received: (nullmailer pid 3141 invoked by uid 1000);\r
+ Mon, 06 Jun 2016 14:58:17 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Richard Russon <rich@flatcap.org>, notmuch@notmuchmail.org\r
+Subject: [PATCH] lib: fix definition of LIBNOTMUCH_CHECK_VERSION\r
+Date: Mon,  6 Jun 2016 11:58:15 -0300\r
+Message-Id: <1465225095-3098-1-git-send-email-david@tethera.net>\r
+X-Mailer: git-send-email 2.1.4\r
+In-Reply-To: <20160606124522.g2y2eazhhrwjsa4h@flatcap.org>\r
+References: <20160606124522.g2y2eazhhrwjsa4h@flatcap.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 06 Jun 2016 15:34:06 -0000\r
+\r
+Fix bug reported in id:20160606124522.g2y2eazhhrwjsa4h@flatcap.org\r
+\r
+Although the C99 standard 6.10 is a little non-obvious on this point,\r
+the docs for e.g. gcc are unambiguous. And indeed in practice with the\r
+extra space, this code fails\r
+\r
+int main(int argc, char **argv){\r
+  printf("%d\n",foo(1));\r
+}\r
+---\r
+ lib/notmuch.h | 2 +-\r
+ 1 file changed, 1 insertion(+), 1 deletion(-)\r
+\r
+diff --git a/lib/notmuch.h b/lib/notmuch.h\r
+index 29713ae..d4a97cb 100644\r
+--- a/lib/notmuch.h\r
++++ b/lib/notmuch.h\r
+@@ -93,7 +93,7 @@ NOTMUCH_BEGIN_DECLS\r
+  * #endif\r
+  * @endcode\r
+  */\r
+-#define LIBNOTMUCH_CHECK_VERSION (major, minor, micro)                        \\r
++#define LIBNOTMUCH_CHECK_VERSION(major, minor, micro)                 \\r
+     (LIBNOTMUCH_MAJOR_VERSION > (major) ||                                    \\r
+      (LIBNOTMUCH_MAJOR_VERSION == (major) && LIBNOTMUCH_MINOR_VERSION > (minor)) || \\r
+      (LIBNOTMUCH_MAJOR_VERSION == (major) && LIBNOTMUCH_MINOR_VERSION == (minor) && \\r
+-- \r
+2.1.4\r
+\r