Re: [PATCH] emacs: tweak error buffer handling

diff --git a/83/9313873efdf59659e5c4bfc09e3b16c5a2a302 b/83/9313873efdf59659e5c4bfc09e3b16c5a2a302
new file mode 100644 (file)
index 0000000..d85fd30
--- /dev/null
+++ b/83/9313873efdf59659e5c4bfc09e3b16c5a2a302
@@ -0,0 +1,119 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9E294431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 25 Dec 2012 13:06:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id TBWLWOXjbK53 for <notmuch@notmuchmail.org>;\r
+       Tue, 25 Dec 2012 13:05:59 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 80CCE431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 25 Dec 2012 13:05:59 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 00C981000F2;\r
+       Tue, 25 Dec 2012 23:05:51 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: tweak error buffer handling\r
+In-Reply-To: <1356209345-11712-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1356209345-11712-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.14+216~gd58661f (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 25 Dec 2012 23:05:51 +0200\r
+Message-ID: <m2y5glvo40.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 25 Dec 2012 21:06:01 -0000\r
+\r
+On Sat, Dec 22 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> view-mode-enter changed between emacs 23 and emacs 24: the current\r
+> code makes the error buffer disappear in emacs 24 on quitting it (ie\r
+> pressing q) but this just kills the buffer without closing the split\r
+> window in emacs 23.\r
+>\r
+> This patch makes the error buffer window disappear in emacs 23\r
+> too. Since the view-mode-enter function changed we have to test for\r
+> version and do the correct thing in each case.\r
+> ---\r
+>\r
+> This seems to work but I have only tested on 23.4 and 24.2\r
+\r
+I run emacs 23.1.1 to get the documentation of view-mode-enter\r
+there. So, this patch instructs to delete WINDOW when exiting\r
+view mode...\r
+\r
+Documentation of pop-to-buffer says:\r
+\r
+"Select buffer BUFFER-OR-NAME in some window, preferably a different one."\r
+\r
+What if pop-up-windows's value is nil -- the content of current window\r
+is replaced with this view stuff -- and when exiting view mode, the\r
+window will be deleted ? What happens with emacs 24 in this case ?\r
+\r
+Tomi\r
+\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+>\r
+>  emacs/notmuch-lib.el |    8 +++++---\r
+>  1 files changed, 5 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
+> index 77a591d..0407f8a 100644\r
+> --- a/emacs/notmuch-lib.el\r
+> +++ b/emacs/notmuch-lib.el\r
+> @@ -324,15 +324,17 @@ the user dismisses it."\r
+>  \r
+>    (let ((buf (get-buffer-create "*Notmuch errors*")))\r
+>      (with-current-buffer buf\r
+> -      (view-mode-enter nil #'kill-buffer)\r
+> +      (pop-to-buffer buf)\r
+> +      (view-mode-enter (when (< emacs-major-version 24)\r
+> +                       (cons (selected-window) (cons nil t)))\r
+> +                   #'kill-buffer)\r
+>        (let ((inhibit-read-only t))\r
+>      (goto-char (point-max))\r
+>      (unless (bobp)\r
+>        (insert "\n"))\r
+>      (insert msg)\r
+>      (unless (bolp)\r
+> -      (insert "\n"))))\r
+> -    (pop-to-buffer buf)))\r
+> +      (insert "\n"))))))\r
+>  \r
+>  (defun notmuch-check-async-exit-status (proc msg)\r
+>    "If PROC exited abnormally, pop up an error buffer and signal an error.\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r