Re: [PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

diff --git a/72/a7323411d7619d133d8e51db4c78b97fe149c8 b/72/a7323411d7619d133d8e51db4c78b97fe149c8
new file mode 100644 (file)
index 0000000..9d4d1ce
--- /dev/null
+++ b/72/a7323411d7619d133d8e51db4c78b97fe149c8
@@ -0,0 +1,103 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E3FEC431FD7\r
+       for <notmuch@notmuchmail.org>; Thu, 26 Feb 2015 11:10:43 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.438\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ER6HPYt7JDbV for <notmuch@notmuchmail.org>;\r
+       Thu, 26 Feb 2015 11:10:40 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9FCB3431FD2\r
+       for <notmuch@notmuchmail.org>; Thu, 26 Feb 2015 11:10:40 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 296AD10019F;\r
+       Thu, 26 Feb 2015 21:04:27 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: "J. Lewis Muir" <jlmuir@imca-cat.org>\r
+Subject: Re: [PATCH] lib: make notmuch shared library install_name be full\r
+       path on Mac OS X\r
+In-Reply-To: <20150226181423.GA2822@bass.imca.aps.anl.gov>\r
+References: <1409541227-38895-1-git-send-email-jlmuir@imca-cat.org>\r
+       <87twyao35q.fsf@maritornes.cs.unb.ca>\r
+       <20150226181423.GA2822@bass.imca.aps.anl.gov>\r
+User-Agent: Notmuch/0.19+53~gb45d2f9 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 26 Feb 2015 21:04:26 +0200\r
+Message-ID: <m2mw404hqd.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 26 Feb 2015 19:10:44 -0000\r
+\r
+On Thu, Feb 26 2015, "J. Lewis Muir" <jlmuir@imca-cat.org> wrote:\r
+\r
+> On 2/25/15 1:34 AM, David Bremner wrote:\r
+>> Unfortunately we did not receive any feedback from Mac users in the\r
+>> meantime. It would be nice to know that your patch won't break the\r
+>> existing macports and brew packages.  I suppose that those work\r
+>> because they install the libraries into a well known location.\r
+>\r
+> Hi, David.\r
+>\r
+> I just tried installing to /usr/local (now on OS X Yosemite 10.10.2),\r
+> and you're right about that; it appears that because it's a standard\r
+> location, it works without my patch.  Looking at the dyld(1) man page,\r
+> it says the following for the DYLD_FALLBACK_LIBRARY_PATH environment\r
+> variable (and I think the fact that /usr/local/lib is in the default\r
+> list is the reason why it works without the patch):\r
+>\r
+>   This is a colon separated list of directories that contain\r
+>   libraries.  It is used as the default location for libraries\r
+>   not found in their install path.  By default, it is set to\r
+>   $(HOME)/lib:/usr/local/lib:/lib:/usr/lib.\r
+>\r
+> However, if I install to /opt, it does *not* work without my patch.  So,\r
+> I'm still confident that the patch is correct and needed.\r
+\r
+It definitely make sense that when loading "dynamically linked" binary,\r
+and the names of the libraries it tries to open do not contain '/':s (or\r
+perhaps is not absolute), the system attempts to find it from pre-defined\r
+location -- and (possibly) otherwise uses the path coded in the name\r
+\r
+The commit message is just (IMO) somewhat confusing; what is this\r
+\r
+  $ otool -L /opt/notmuch-current/lib/libnotmuch.dylib\r
+\r
+is there files /opt/notmuch-current/lib/libnotmuch.dylib and\r
+/opt/notmuch-current/lib/libnotmuch.3.dylib in the fs -- and\r
+what does otool -L opt/notmuch-current/bin/notmuch output\r
+\r
+As a non-mac user it is hard to review this when full visibility\r
+to the file system is not available...\r
+\r
+>\r
+> Regards,\r
+>\r
+> Lewis\r
+\r
+\r
+Tomi\r
+\r