Re: [PATCH v6 02/12] tag-util: do not reset list in parse_tag_command_line

diff --git a/32/382f2802b2bcac2a8e9f850243390f971cdec0 b/32/382f2802b2bcac2a8e9f850243390f971cdec0
new file mode 100644 (file)
index 0000000..530ffbd
--- /dev/null
+++ b/32/382f2802b2bcac2a8e9f850243390f971cdec0
@@ -0,0 +1,124 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 081D5431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 23:52:16 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id MgaPYYuWx9tB for <notmuch@notmuchmail.org>;\r
+       Fri, 21 Jun 2013 23:52:08 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 0B04D431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 23:52:08 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1UqHg5-000162-Hl; Sat, 22 Jun 2013 07:52:06 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1UqHg5-0008Sb-8s; Sat, 22 Jun 2013 07:52:05 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v6 02/12] tag-util: do not reset list in\r
+       parse_tag_command_line\r
+In-Reply-To: <1371880008-18312-3-git-send-email-novalazy@gmail.com>\r
+References: <1371880008-18312-1-git-send-email-novalazy@gmail.com>\r
+       <1371880008-18312-3-git-send-email-novalazy@gmail.com>\r
+User-Agent: Notmuch/0.15.2+171~ge2f30a2 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 22 Jun 2013 07:52:02 +0100\r
+Message-ID: <87mwqivdrh.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: fbab1e3826fac83e5935b15cb239dec2 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -0.0 points.\r
+       Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 22 Jun 2013 06:52:16 -0000\r
+\r
+\r
+\r
+> No current callers of parse_tag_command_line require that it clear its\r
+> tag list argument.  The notmuch 'insert' command will be better served\r
+> if the function modifies a pre-populated list (of new.tags) instead of\r
+> clobbering it outright.\r
+\r
+As far as I can see there is now only 1 caller of\r
+parse_tag_command_line. Assuming I am correct can we make this "As the\r
+unique current caller of parse_tag_command_line does not require..."\r
+\r
+Best wishes\r
+\r
+Mark\r
+  \r
+> ---\r
+>  tag-util.c | 2 --\r
+>  tag-util.h | 2 ++\r
+>  2 files changed, 2 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/tag-util.c b/tag-util.c\r
+> index 92e08a1..3bde409 100644\r
+> --- a/tag-util.c\r
+> +++ b/tag-util.c\r
+> @@ -165,8 +165,6 @@ parse_tag_command_line (void *ctx, int argc, char **argv,\r
+>  \r
+>      int i;\r
+>  \r
+> -    tag_op_list_reset (tag_ops);\r
+> -\r
+>      for (i = 0; i < argc; i++) {\r
+>      if (strcmp (argv[i], "--") == 0) {\r
+>          i++;\r
+> diff --git a/tag-util.h b/tag-util.h\r
+> index 246de85..4628f16 100644\r
+> --- a/tag-util.h\r
+> +++ b/tag-util.h\r
+> @@ -81,6 +81,8 @@ parse_tag_line (void *ctx, char *line,\r
+>   * Output Parameters:\r
+>   *  ops     contains a list of tag operations\r
+>   *  query_str the search terms.\r
+> + *\r
+> + * The ops argument is not cleared.\r
+>   */\r
+>  \r
+>  tag_parse_status_t\r
+> -- \r
+> 1.7.12.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r