--- /dev/null
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 2710A431FD4\r
+ for <notmuch@notmuchmail.org>; Thu, 5 Dec 2013 12:05:13 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+ RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id IlFzJtoFwl1W for <notmuch@notmuchmail.org>;\r
+ Thu, 5 Dec 2013 12:05:07 -0800 (PST)\r
+Received: from mail-we0-f176.google.com (mail-we0-f176.google.com\r
+ [74.125.82.176]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 59274431E82\r
+ for <notmuch@notmuchmail.org>; Thu, 5 Dec 2013 12:04:54 -0800 (PST)\r
+Received: by mail-we0-f176.google.com with SMTP id w62so11260876wes.7\r
+ for <notmuch@notmuchmail.org>; Thu, 05 Dec 2013 12:04:53 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:cc:subject:date:message-id:in-reply-to:references;\r
+ bh=38kBFyaVG/U8ecXRO6b/rSrEm6hrIhK+vDh1pkNIWBg=;\r
+ b=OVcGr4nF6Au1KjZu6GIWa02WnFYJcUfG79EXoL6I52COfBYXXgCdelfpEdiBodlxi0\r
+ fGBBwz4RQxjq0b2xv6ea9LnG5BRpc/bHPJ4mXanan3Zt3a1cuD5qP5I34LyB9BmYcAfI\r
+ KqfO8mMRy3Ue8eYu9shvDx4vIV2UGnq7mp4L5XA06ze313f/JfbLDUZWzSELamm/FULL\r
+ /N5s0p9r09tJpVmfgzpMMfJ5yMgJi/yalRKAxdWyhDaZ38DZKj5OVOUhNiSBPPwR/g/W\r
+ 2SSGzXbilzJ5ZDExqbOjvtQrCxL+WBpZorxqu1KayGFed4CWr/c9DpPnmZRjTfhs+2CN\r
+ eLrg==\r
+X-Received: by 10.180.10.74 with SMTP id g10mr430150wib.11.1386273893044;\r
+ Thu, 05 Dec 2013 12:04:53 -0800 (PST)\r
+Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])\r
+ by mx.google.com with ESMTPSA id g16sm9420608wiw.6.2013.12.05.12.04.51\r
+ for <multiple recipients>\r
+ (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+ Thu, 05 Dec 2013 12:04:52 -0800 (PST)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH WIP v3 3/3] emacs: show: make `seen' mean user viewed whole\r
+ message\r
+Date: Thu, 5 Dec 2013 20:04:31 +0000\r
+Message-Id: <1386273871-24214-4-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.9.1\r
+In-Reply-To: <1386273871-24214-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1386273871-24214-1-git-send-email-markwalters1009@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 05 Dec 2013 20:05:13 -0000\r
+\r
+This changes `seen' to mean that the user viewed `enough' of the whole\r
+message: more precisely, a message is deemed seen if the top of the\r
+message and either the bottom of the message or a point at least some\r
+customisable number of lines into the message have each been visible\r
+in the buffer at some point.\r
+\r
+This is placed into the post-command-hook infrastructure introudced in\r
+the previous patch.\r
+---\r
+ emacs/notmuch-show.el | 74 +++++++++++++++++++++++++++++++++++++++++++++++-\r
+ 1 files changed, 72 insertions(+), 2 deletions(-)\r
+\r
+diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+index 7d0ac5d..6451314 100644\r
+--- a/emacs/notmuch-show.el\r
++++ b/emacs/notmuch-show.el\r
+@@ -211,6 +211,20 @@ For example, if you wanted to remove an \"unread\" tag and add a\r
+ :type '(repeat string)\r
+ :group 'notmuch-show)\r
+ \r
++(defcustom notmuch-show-seen-lines-needed 0.75\r
++ "Control which messages get marked seen.\r
++\r
++A message is marked seen if both the top of the message and a\r
++point far \"enough\" down in the message have each been visible\r
++in the buffer at some point. This parameter controls the\r
++definition of enough. Seeing the bottom of message is always\r
++deemed enough, but additionally...it an integer n then at least n\r
++lines of message must be visible in the window. If it is a float\r
++x then at least that proportion of the window must contain the\r
++message."\r
++ :type 'number\r
++ :group 'notmuch-show)\r
++\r
+ (defface notmuch-show-deleted-tag-face\r
+ '((t :strike-through "red" :inherit 'notmuch-tag-face))\r
+ "Face for tags that have been removed"\r
+@@ -1551,9 +1565,65 @@ marked as unread, i.e. the tag changes in\r
+ (apply 'notmuch-show-tag-message\r
+ (notmuch-tag-change-list notmuch-show-mark-read-tags unread))))\r
+ \r
++(defun notmuch-show-update-seen (top-or-bottom)\r
++ "Update seen status of current message\r
++\r
++Mark that we have seen the TOP-OR-BOTTOM of current message."\r
++ (let* ((current (notmuch-show-get-prop :seen-local))\r
++ new)\r
++ (unless (eq current 'both)\r
++ (if (eq top-or-bottom 'top)\r
++ (if (eq current 'bottom)\r
++ (setq new 'both)\r
++ (setq new 'top))\r
++ (if (eq current 'top)\r
++ (setq new 'both)\r
++ (setq new 'bottom)))\r
++ (unless (eq current new)\r
++ (notmuch-show-set-prop :seen-local new))\r
++ (when (eq new 'both)\r
++ (notmuch-show-mark-read)))))\r
++\r
++(defun notmuch-show-do-message-seen (start end)\r
++ "Update seen status for the current message.\r
++\r
++A message is seen if both the top and enough of the rest of the\r
++message have been visible in the buffer. Enough means either the\r
++bottom of the message or a point in the message more than\r
++LINES-NEEDED lines into the message. LINES-NEEDED is\r
++`notmuch-show-seen-lines-needed` if that is an integer and that\r
++times the current window height if it is a float."\r
++ (let* ((lines-needed (if (integerp notmuch-show-seen-lines-needed)\r
++ notmuch-show-seen-lines-needed\r
++ (truncate (* notmuch-show-seen-lines-needed (window-body-height)))))\r
++ (top (notmuch-show-message-top))\r
++ (bottom (notmuch-show-message-bottom)))\r
++ (when (notmuch-show-message-visible-p)\r
++ (when (>= top start)\r
++ (notmuch-show-update-seen 'top))\r
++ (when (or (<= bottom end)\r
++ (> (count-screen-lines top end) lines-needed))\r
++ (notmuch-show-update-seen 'bottom)))))\r
++\r
+ (defun notmuch-show-do-seen (start end)\r
+- "Update seen status for all messages between start and end."\r
+- )\r
++ "Update seen status for all messages between start and end.\r
++\r
++A message is seen if both the top and enough of the rest of the\r
++message have been visible in the buffer. See\r
++`notmuch-show-do-message-seen` for the definition of enough. Seen\r
++is a buffer local property. The unread status is removed from all\r
++seen messages when the user quits the show buffer."\r
++ (save-excursion\r
++ (goto-char start)\r
++ (while (and (or (notmuch-show-do-message-seen start end) t)\r
++ (< (notmuch-show-message-bottom) end)\r
++ (notmuch-show-goto-message-next)))\r
++\r
++ ;; This is a work around because emacs gives weird answers for\r
++ ;; window-end if the buffer ends with invisible text.\r
++ (when (and (pos-visible-in-window-p (point-max))\r
++ (notmuch-show-message-visible-p))\r
++ (notmuch-show-update-seen 'bottom))))\r
+ \r
+ (defun notmuch-show-command-hook ()\r
+ (when (eq major-mode 'notmuch-show-mode)\r
+-- \r
+1.7.9.1\r
+\r
projects / notmuch-archives.git / commitdiff