Re: [PATCH] configure: drop use of "pkg-config emacs"
authorTomi Ollila <tomi.ollila@iki.fi>
Sun, 6 Dec 2015 18:10:15 +0000 (20:10 +0200)
committerW. Trevor King <wking@tremily.us>
Sat, 20 Aug 2016 21:50:07 +0000 (14:50 -0700)
95/0a033c057e3c03821d3d932edc754a3c57f5e9 [new file with mode: 0644]

diff --git a/95/0a033c057e3c03821d3d932edc754a3c57f5e9 b/95/0a033c057e3c03821d3d932edc754a3c57f5e9
new file mode 100644 (file)
index 0000000..4d85a70
--- /dev/null
@@ -0,0 +1,102 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id D4A1D6DE13ED\r
+ for <notmuch@notmuchmail.org>; Sun,  6 Dec 2015 10:10:09 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.707\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.707 tagged_above=-999 required=5 tests=[AWL=0.055, \r
+ SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 5mqnPQahalFH for <notmuch@notmuchmail.org>;\r
+ Sun,  6 Dec 2015 10:10:07 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id ED8B86DE13DB\r
+ for <notmuch@notmuchmail.org>; Sun,  6 Dec 2015 10:10:06 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 8CAEE100046;\r
+ Sun,  6 Dec 2015 20:10:15 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>,\r
+ Andrew Burgess <andrew.burgess@embecosm.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] configure: drop use of "pkg-config emacs"\r
+In-Reply-To: <1449418220-17790-1-git-send-email-david@tethera.net>\r
+References: <m2k2p2rwth.fsf@guru.guru-group.fi>\r
+ <1449418220-17790-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 06 Dec 2015 20:10:15 +0200\r
+Message-ID: <m2d1ujjvnc.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 06 Dec 2015 18:10:10 -0000\r
+\r
+On Sun, Dec 06 2015, David Bremner <david@tethera.net> wrote:\r
+\r
+> This does not play well with --prefix. As Tomi notes in\r
+> id:m2k2p2rwth.fsf@guru.guru-group.fi, people still have the option of e.g.\r
+>\r
+> % ./configure ---emacslispdir=`pkg-config emacs --variable sitepkglispdir`\r
+> ---\r
+> oops, I missed a second use of pkg-config emacs\r
+\r
+LGTM. Patch applies. I cannot see how this could fail...\r
+\r
+Tomi\r
+\r
+>\r
+> configure | 12 ++----------\r
+>  1 file changed, 2 insertions(+), 10 deletions(-)\r
+>\r
+> diff --git a/configure b/configure\r
+> index 440d678..abd28da 100755\r
+> --- a/configure\r
+> +++ b/configure\r
+> @@ -472,19 +472,11 @@ else\r
+>  fi\r
+>  \r
+>  if [ -z "${EMACSLISPDIR}" ]; then\r
+> -    if pkg-config --exists emacs; then\r
+> -    EMACSLISPDIR=$(pkg-config emacs --variable sitepkglispdir)\r
+> -    else\r
+> -    EMACSLISPDIR='$(prefix)/share/emacs/site-lisp'\r
+> -    fi\r
+> +    EMACSLISPDIR='$(prefix)/share/emacs/site-lisp'\r
+>  fi\r
+>  \r
+>  if [ -z "${EMACSETCDIR}" ]; then\r
+> -    if pkg-config --exists emacs; then\r
+> -    EMACSETCDIR=$(pkg-config emacs --variable sitepkglispdir)\r
+> -    else\r
+> -    EMACSETCDIR='$(prefix)/share/emacs/site-lisp'\r
+> -    fi\r
+> +    EMACSETCDIR='$(prefix)/share/emacs/site-lisp'\r
+>  fi\r
+>  \r
+>  printf "Checking if emacs is available... "\r
+> -- \r
+> 2.6.2\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> https://notmuchmail.org/mailman/listinfo/notmuch\r