Re: [notmuch] pull request [was Re: pull request]

diff --git a/84/c9bb134e5070e44eaba5751f2b70eefd020f3b b/84/c9bb134e5070e44eaba5751f2b70eefd020f3b
new file mode 100644 (file)
index 0000000..5b652fc
--- /dev/null
+++ b/84/c9bb134e5070e44eaba5751f2b70eefd020f3b
@@ -0,0 +1,85 @@
+Return-Path: <bremner@pivot.cs.unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 61BCB4196F4\r
+       for <notmuch@notmuchmail.org>; Sat,  3 Apr 2010 14:22:05 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.9\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5\r
+       tests=[BAYES_00=-1.9] autolearn=unavailable\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id FR-8HeeSfHlh for <notmuch@notmuchmail.org>;\r
+       Sat,  3 Apr 2010 14:22:05 -0700 (PDT)\r
+Received: from pivot.cs.unb.ca (pivot.cs.unb.ca [131.202.240.57])\r
+       by olra.theworths.org (Postfix) with ESMTP id 091A34196F2\r
+       for <notmuch@notmuchmail.org>; Sat,  3 Apr 2010 14:22:05 -0700 (PDT)\r
+Received: from\r
+       fctnnbsc30w-142167190087.pppoe-dynamic.high-speed.nb.bellaliant.net\r
+       ([142.167.190.87] helo=rocinante.cs.unb.ca)\r
+       by pivot.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.69) (envelope-from <bremner@pivot.cs.unb.ca>)\r
+       id 1NyAn5-0002GY-3l; Sat, 03 Apr 2010 18:22:03 -0300\r
+Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.71)\r
+       (envelope-from <bremner@rocinante.cs.unb.ca>)\r
+       id 1NyAmz-0007BP-A6; Sat, 03 Apr 2010 18:21:57 -0300\r
+From: David Bremner <bremner@unb.ca>\r
+To: Carl Worth <cworth@cworth.org>, David Edmondson <dme@dme.org>, notmuch\r
+       <notmuch@notmuchmail.org>\r
+In-Reply-To: <87tyrsz5rp.fsf@yoom.home.cworth.org>\r
+References: <87oci344n4.fsf@ut.hh.sledj.net>\r
+       <87bpe2j2vu.fsf@yoom.home.cworth.org> <87oci2xmkv.fsf@ut.hh.sledj.net>\r
+       <87d3yhihzl.fsf@yoom.home.cworth.org> <87k4spxcz7.fsf@ut.hh.sledj.net>\r
+       <87tyrsz5rp.fsf@yoom.home.cworth.org>\r
+Date: Sat, 03 Apr 2010 18:21:57 -0300\r
+Message-ID: <87pr2gs03u.fsf@rocinante.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Verified: bremner@pivot.cs.unb.ca\r
+Subject: Re: [notmuch] pull request [was Re:  pull request]\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 03 Apr 2010 21:22:05 -0000\r
+\r
+On Sat, 03 Apr 2010 12:37:46 -0700, Carl Worth <cworth@cworth.org> wrote:\r
+> \r
+> If I apply this patch as is, then when compiling the notmuch-show.el I\r
+> get the following warnings:\r
+> \r
+>   In notmuch-show:\r
+>   notmuch-show.el:969:34:Warning: reference to free variable `notmuch-command'\r
+> \r
+>   In end of data:\r
+>   notmuch-show.el:983:1:Warning: the following functions are not known to be\r
+>       defined: point-invisible-p, mail-header-extract-no-properties,\r
+>       notmuch-select-tag-with-completion, union, intersection, set-difference,\r
+>       notmuch-search-show-thread, mm-display-parts, mm-dissect-buffer,\r
+>       notmuch-save-attachments, notmuch-count-attachments, notmuch-reply,\r
+>       mm-handle-type, mm-display-part, notmuch-fontify-headers\r
+> \r
+\r
+This is my understanding from staring at the code for a few other\r
+packages; any experts feel free to contradict.\r
+\r
+The warnings about unknown functions can be eliminated by use the\r
+declare-function macro; if you have emacs lisp reference manual (it\r
+required the package emacs23-common-non-dfsg on Debian) then you can\r
+run:\r
+\r
+ESC ESC : (info "(elisp)Declaring Functions") <RETURN>\r
+\r
+For variables, the obvious approach is to make a file 'notmuch-vars.el'\r
+and put the variables we need in several files there.\r