Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

diff --git a/d5/4e01e6df2a42f20562fa2257aea77a16bb9e71 b/d5/4e01e6df2a42f20562fa2257aea77a16bb9e71
new file mode 100644 (file)
index 0000000..93c7dcd
--- /dev/null
+++ b/d5/4e01e6df2a42f20562fa2257aea77a16bb9e71
@@ -0,0 +1,95 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 583D2431FBC\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 12:43:21 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id VHApxB1r2lER for <notmuch@notmuchmail.org>;\r
+       Tue, 28 Oct 2014 12:43:16 -0700 (PDT)\r
+Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com\r
+ [74.125.82.53])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ A1BB6431FB6   for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 12:43:16 -0700\r
+ (PDT)\r
+Received: by mail-wg0-f53.google.com with SMTP id b13so274039wgh.40\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 12:43:15 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=S/fgXWs0ifvP5FChoiwDkjvs8LJEhWKkd4i7RSHWKJM=;\r
+       b=CSHvUJtJKSfVsVi+jqNjokT/unk0HOYy7hPmuMuzxwphEkY7T55F28GbmIzJ40uZUW\r
+       BcbpOpJkbqiGDiT6xTSMA04N0J1KtmDNS4UslI9xpkKKe2gKzjI5MZHhNr+tkcUBQ1ua\r
+       jInhPV0JNaPwBYvmedphvvHdWSN5FKjsn31IcV6a+eI3AR7KRexx61In91KWNSeXBczn\r
+       TbUOSJhkubX4sejB0/g/lqVMHBji9O6XpWpfK91qZ9QcVW+Hqa9m1QVJC/kcWF1/yXRu\r
+       f4MMAcu2aawLEIs6K/nIMixSfW2plbb2c5xKXhB7LmRHxOaj10m9ANCheX9Rq3XJXSN6\r
+       +Qsw==\r
+X-Gm-Message-State:\r
+ ALoCoQk3V8XmsME4Wq3nRMxXoDB+c+Qo46a/WpQHyZ8y7rT6Eo13Zk8P92iTmR5WzJj9GjKMZJXQ\r
+X-Received: by 10.180.76.41 with SMTP id h9mr7490232wiw.40.1414525395324;\r
+       Tue, 28 Oct 2014 12:43:15 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c36d-48.dhcp.inet.fi.\r
+       [88.195.109.48])\r
+       by mx.google.com with ESMTPSA id u13sm1755264wiv.10.2014.10.28.12.43.14\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Tue, 28 Oct 2014 12:43:14 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test\r
+In-Reply-To: <87a94g2h7t.fsf@maritornes.cs.unb.ca>\r
+References: <1414518754-16344-1-git-send-email-jani@nikula.org>\r
+       <87a94g2h7t.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.18.2+148~g4214adf (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 28 Oct 2014 21:43:12 +0200\r
+Message-ID: <877fzk0ylr.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 28 Oct 2014 19:43:21 -0000\r
+\r
+On Tue, 28 Oct 2014, David Bremner <david@tethera.net> wrote:\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>\r
+>> You need to actually check the return value. Limit the missing deps\r
+>> part to subtests requiring gdb.\r
+>\r
+> For me, on a system without gdb, the current version looks like\r
+>\r
+> T070-insert: Testing "notmuch insert"\r
+>  missing prerequisites: gdb(1)\r
+>  SKIP   all tests in T070-insert\r
+>\r
+> This seems OK to me?\r
+\r
+More than okay. /me hides.\r
+\r
+> Of course you're right that moving it forward to only skip the gdb\r
+> requiring tests is the right thing to do, and in that setting having a\r
+> skipped message for all 10 skipped tests is a bit ugly. OTOHO your\r
+> version doesn't give any output at all, which seems not perfect either.\r
+\r
+How does it work if you just move the prereq test forward?\r
+\r
+BR,\r
+Jani.\r