Re: [PATCH] add has: query prefix to search for specific properties

diff --git a/ed/5394975916606ee573f319067868873945e88f b/ed/5394975916606ee573f319067868873945e88f
new file mode 100644 (file)
index 0000000..3effd8e
--- /dev/null
+++ b/ed/5394975916606ee573f319067868873945e88f
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id B02226DE0140\r
+ for <notmuch@notmuchmail.org>; Sun, 17 Jul 2016 03:38:25 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.011\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.011 tagged_above=-999 required=5 tests=[AWL=0.000,\r
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id fqSpxGyx_Pih for <notmuch@notmuchmail.org>;\r
+ Sun, 17 Jul 2016 03:38:17 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 3B15F6DE0130\r
+ for <notmuch@notmuchmail.org>; Sun, 17 Jul 2016 03:38:17 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1bOjT1-0005aS-5m; Sun, 17 Jul 2016 06:38:35 -0400\r
+Received: (nullmailer pid 609 invoked by uid 1000);\r
+ Sun, 17 Jul 2016 10:38:10 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH] add has: query prefix to search for specific properties\r
+In-Reply-To: <87ziphxfl2.fsf@zancas.localnet>\r
+References: <1465779955-5539-9-git-send-email-david@tethera.net>\r
+ <1467969336-7605-1-git-send-email-dkg@fifthhorseman.net>\r
+ <87ziphxfl2.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.22+28~gb9bf3f4 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 17 Jul 2016 07:38:10 -0300\r
+Message-ID: <87wpkky2gd.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 17 Jul 2016 10:38:25 -0000\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> Do we want to have the same prefix listed in BOOLEAN_PREFIX_INTERNAL and\r
+> BOOLEAN_PREFIX_EXTERNAL? this seems quite fragile. If we don't though,\r
+> we have to use the same prefix name for queries as in the code (which is\r
+> already sprinkled with _find_prefix ("property") ).\r
+\r
+Thinking about it a bit more, there's really no problem here. The\r
+invariant to maintain is the names are unique across all 3 tables used\r
+by _find_prefix, not the necessarily the prefixes. Indeed there's\r
+already the example of "is" and "tag".\r
+\r
+d\r