Re: [PATCH 1/3] emacs: Fix mail composition under Emacs 23

diff --git a/f3/717a2566653f8663456b26830602980335f07d b/f3/717a2566653f8663456b26830602980335f07d
new file mode 100644 (file)
index 0000000..a1adc82
--- /dev/null
+++ b/f3/717a2566653f8663456b26830602980335f07d
@@ -0,0 +1,84 @@
+Return-Path: <wsh@2x.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 54E2E6DE100C\r
+ for <notmuch@notmuchmail.org>; Wed,  6 Jan 2016 13:27:56 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.55\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.55 tagged_above=-999 required=5 tests=[AWL=0.760, \r
+ RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01,\r
+ RCVD_IN_MSPIKE_WL=-0.01, T_HEADER_FROM_DIFFERENT_DOMAINS=0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id rwTO07qA6HCB for <notmuch@notmuchmail.org>;\r
+ Wed,  6 Jan 2016 13:27:53 -0800 (PST)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 280046DE1003\r
+ for <notmuch@notmuchmail.org>; Wed,  6 Jan 2016 13:27:52 -0800 (PST)\r
+Received: from localhost (unknown [192.168.200.7])\r
+ by max.feld.cvut.cz (Postfix) with ESMTP id E27D619F49CC;\r
+ Wed,  6 Jan 2016 22:27:49 +0100 (CET)\r
+X-Virus-Scanned: IMAP STYX AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+ by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new, port 10044)\r
+ with ESMTP id S05iBpI4b3bB; Wed,  6 Jan 2016 22:27:48 +0100 (CET)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+ by max.feld.cvut.cz (Postfix) with ESMTP id 403C719F477C;\r
+ Wed,  6 Jan 2016 22:27:47 +0100 (CET)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.86)\r
+ (envelope-from <wsh@2x.cz>)\r
+ id 1aGvcQ-000527-4B; Wed, 06 Jan 2016 22:27:46 +0100\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] emacs: Fix mail composition under Emacs 23\r
+In-Reply-To: <8760z8ah7e.fsf@zancas.localnet>\r
+References: <1451753265-26713-1-git-send-email-sojkam1@fel.cvut.cz>\r
+ <1451753265-26713-2-git-send-email-sojkam1@fel.cvut.cz>\r
+ <8760z8ah7e.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.21+30~g55c056a (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 06 Jan 2016 22:27:46 +0100\r
+Message-ID: <87ziwiv1nx.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 06 Jan 2016 21:27:56 -0000\r
+\r
+On Tue, Jan 05 2016, David Bremner wrote:\r
+> Michal Sojka <sojkam1@fel.cvut.cz> writes:\r
+>\r
+>> +    (when return-action (nconc args '(return-action)))\r
+>> +    (apply 'message-setup-1\r
+>> +      ;; The following sexp is copied from `message-mail'\r
+>\r
+>> +      (nconc\r
+>> +       `((To . ,(or to "")) (Subject . ,(or subject "")))\r
+>\r
+> I missed this the first time, but I a bit worried about this used of\r
+> nconc. It seems to fall under "A common pitfall is to use a quoted\r
+> constant list as a non-last argument to =E2=80=98nconc=E2=80=99"  (from t=\r
+he elisp\r
+> manual).  In any case it's not really performance critical code (I\r
+> guess?) so maybe we could just use append?\r
+\r
+Yes, this make sense. As the nconc is already in master, I'll not\r
+combine the fix for this with 1/3, but I'm sending a separate patch that\r
+applies after 3/3.\r
+\r
+-Michal\r