Re: V2 of batch-tagging plus new dump/restore

diff --git a/c7/b4befd13b1104943513d2694af6664b987f684 b/c7/b4befd13b1104943513d2694af6664b987f684
new file mode 100644 (file)
index 0000000..f0bcee9
--- /dev/null
+++ b/c7/b4befd13b1104943513d2694af6664b987f684
@@ -0,0 +1,124 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2B6AD431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Dec 2012 06:47:26 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5G3ETPjWz6z7 for <notmuch@notmuchmail.org>;\r
+       Sun,  2 Dec 2012 06:47:21 -0800 (PST)\r
+Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com\r
+       [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 76DF4431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Dec 2012 06:47:21 -0800 (PST)\r
+Received: by mail-lb0-f181.google.com with SMTP id ge1so1792623lbb.26\r
+       for <notmuch@notmuchmail.org>; Sun, 02 Dec 2012 06:47:20 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type:x-gm-message-state;\r
+       bh=w95pW4lesVOiMnQbtOaYbBia5XNZ/gajsqNgV/Xdf74=;\r
+       b=mznj0jkaNEB8MQh903n/9sIQfrHtekld2VucdGg4/m+Jd9tTXc0KCzO3Cs5s45yYjU\r
+       kJV+R0RllTxgHIRU9c3wSM1W0JuyTOnMdUTAdjno3KpTnl76Xi8qVnBbtlECc57gyPMc\r
+       PMelQSQbau1ABF5NM0IsqQB3gZ2Ti4TaEec4feVweYUYWwzDEvXkQqQGtXunKVWmqlqz\r
+       g5mNg6+uVRR47S0wHGNZelqDvaAPpBg+q2Frfx/39vfD9Beqn/pP/p2yznkPxP1ePXFR\r
+       6ayTokCV0UV4X2vtNjRgw7y2BYEVcb8qWFbQoh0TjWfRy2O5pQWy6Fo78nBPjB4YGDbL\r
+       6s7A==\r
+Received: by 10.152.108.197 with SMTP id hm5mr6769487lab.45.1354459639951;\r
+       Sun, 02 Dec 2012 06:47:19 -0800 (PST)\r
+Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi.\r
+       [80.223.81.27])\r
+       by mx.google.com with ESMTPS id gt17sm4099896lab.6.2012.12.02.06.47.18\r
+       (version=SSLv3 cipher=OTHER); Sun, 02 Dec 2012 06:47:19 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: V2 of batch-tagging plus new dump/restore\r
+In-Reply-To: <1353792017-31459-1-git-send-email-david@tethera.net>\r
+References: <1353792017-31459-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+124~g3b17402 (http://notmuchmail.org) Emacs/23.4.1\r
+       (i686-pc-linux-gnu)\r
+Date: Sun, 02 Dec 2012 16:47:16 +0200\r
+Message-ID: <87r4n8cxzf.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQk0JL5a8LFMHTKbtj9d/AXROLOdoH3bnXeoc4kG1GICqEfBP6QIPV894VsQlKXP7LU5+6fJ\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Dec 2012 14:47:26 -0000\r
+\r
+\r
+Hi David -\r
+\r
+Good job! And thanks for resurrecting batch tagging.\r
+\r
+Apart from a few actual bugs and a bag of nitpicks, I think this looks\r
+very good overall. And I don't think any of the issues are very\r
+difficult to fix (some of the nitpicks you can just outright ignore; use\r
+your discretion). We should definitely get this done for the next\r
+release.\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+On Sat, 24 Nov 2012, david@tethera.net wrote:\r
+> this obsoletes: id:1353265498-3839-1-git-send-email-david@tethera.net\r
+>\r
+> Changes based on Mark's review\r
+>\r
+> - add commments for each function  in tag-util.h\r
+>\r
+> - inline tag_op_list_from_string in the one place it was called \r
+>\r
+> - remove NULL terminator from tag_op_list (for mark); along with\r
+>   tag_op_list_t being opaque, I thought is was ok to leave off the\r
+>   comment on ops. But I could be convinced.\r
+>\r
+> - make tag_op_list_t typedef opaque\r
+>\r
+> - add BE_GENEROUS flag to parser. Currently this enables empty tags.\r
+>\r
+> - handle blank lines and comments in restore and batch tagging\r
+>\r
+> - fixed the commit message about "notmuch-new"\r
+>\r
+> Changes based on Ethan's review:\r
+>\r
+> - remove the dreaded . from first line of commit messages\r
+>\r
+> - convert if on l49 of database-test.c into explicit return on error\r
+>\r
+> - add comments and parens for num_tags and this_mid_len in random_corpus.c\r
+>\r
+> - add check for message-id's less than length 1. I wasn't sure why we\r
+>   would disallow all message ids of length 1.\r
+>\r
+> - remove declaration of parse_tag_stream\r
+>\r
+> - explain "query_string += 3"\r
+>\r
+> - fix typo in notmuch-dump.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r