Re: [PATCH v2 0/3] postpone and resume support

diff --git a/18/5efaaeba1459021f9ca6e47b02b952f458272a b/18/5efaaeba1459021f9ca6e47b02b952f458272a
new file mode 100644 (file)
index 0000000..6e79be8
--- /dev/null
+++ b/18/5efaaeba1459021f9ca6e47b02b952f458272a
@@ -0,0 +1,140 @@
+Return-Path: <dkg@fifthhorseman.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 183DA6DE0243\r
+ for <notmuch@notmuchmail.org>; Fri,  3 Jun 2016 11:42:43 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.019\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.019 tagged_above=-999 required=5\r
+ tests=[AWL=-0.019] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id LMuPH4Wk4oNQ for <notmuch@notmuchmail.org>;\r
+ Fri,  3 Jun 2016 11:42:35 -0700 (PDT)\r
+Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 027F46DE0159\r
+ for <notmuch@notmuchmail.org>; Fri,  3 Jun 2016 11:42:34 -0700 (PDT)\r
+Received: from fifthhorseman.net (unknown [38.109.115.130])\r
+ by che.mayfirst.org (Postfix) with ESMTPSA id BB8C3F98B;\r
+ Fri,  3 Jun 2016 14:42:31 -0400 (EDT)\r
+Received: by fifthhorseman.net (Postfix, from userid 1000)\r
+ id 64AA020245; Fri,  3 Jun 2016 14:42:31 -0400 (EDT)\r
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/3] postpone and resume support\r
+In-Reply-To: <1464976195-23134-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1464976195-23134-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.22+47~g4441900 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 03 Jun 2016 14:42:28 -0400\r
+Message-ID: <87eg8eglm3.fsf@alice.fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha512; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 03 Jun 2016 18:42:43 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Fri 2016-06-03 13:49:52 -0400, Mark Walters <markwalters1009@gmail.com> =\r
+wrote:\r
+> This is a new version of the WIP patch at\r
+> id:1464915472-5669-1-git-send-email-markwalters1009@gmail.com\r
+>\r
+> So far it seems to deal with all cases that I have tried, and the\r
+> CAVEATS list is rather smaller than before.\r
+>\r
+> The bindings are C-x C-s to save a draft (in notmuch-message-mode) C-c\r
+> C-p to postpone a draft (ie save and exit buffer), and "e" to resume\r
+> editing from either show or tree mode. You may want to add "draft" to\r
+> your list of excluded tags to hide them unless you specifically search\r
+> for them.\r
+\r
+This is a really useful series, even with the caveats Mark lists.  i've\r
+tested it and it behaves as expected for me.\r
+\r
+A bit more discussion on the caveats:\r
+\r
+> Each save saves a separate copy of the message. We hide these copies\r
+> with the deleted tag but we don't actually delete them. Thus if you\r
+> save several copies of message with large attachments you will use a\r
+> lot of space.\r
+\r
+This is a little bit weird, because it means that all these deleted\r
+drafts show up in the thread view when viewing the thread from which the\r
+message was composed.  Is there a reason to not actually delete older\r
+drafts when "re-postponing" or sending?  We created the message\r
+ourselves, so it seems like it's fair to delete it.\r
+\r
+> If you use signing or encryption then I don't know what will happen:=20\r
+> I have not tested at all.  You might sign a partial message that you\r
+> didn't mean too; you might expose plain text to someone.\r
+\r
+I've just tested this for signing, and it's doing the thing i was afraid\r
+it would do :/ When saving a draft marked as a message to be signed, the\r
+message signature is made on the draft.  Even worse, restoring a saved\r
+draft like this leaves the user editing the plaintext while the old\r
+message signature is likely to be appended, which will result in broken\r
+signatures :/\r
+\r
+Maybe there's a way to temporarily inhibit the interpretation of all\r
+#secure flags during draft saving (and propagate them through upon\r
+resume)?  I think that would be advisable anyway -- if we ultimately\r
+decide that we want to encrypt drafts, we don't want to encrypt them to\r
+the actual recipients anyway; we only want encrypt-to-self, because we\r
+want to avoid the situation where the person we're sending the message\r
+to gets access to our drafts folder and reads our unfinished/unedited\r
+compositions, so that would be a separate and distinct improvement.\r
+\r
+> Finally, and this is not really a caveat, it *may* be possible to resume\r
+> a previously sent message. At the moment I haven't tested this, and\r
+> have made it so that emacs warns before allowing it.\r
+\r
+I've tested it.  It's possible, and it even seems to work :) there are\r
+weird interactions between things like DKIM and modified message-ids,\r
+but i think the warning provided is sufficient to let people know that\r
+if they're doing that sort of thing and something breaks, they get to\r
+keep both pieces.  The biggest danger, i think, is in marking the\r
+non-draft for deletion if a user goes ahead with restoring it.\r
+\r
+          --dkg\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature; name="signature.asc"\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v2\r
+\r
+iQJ8BAEBCgBmBQJXUc+UXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w\r
+ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFREIyRTc0RjU2RkNGMkI2NzI5N0I3MzUy\r
+NEVDRkY1QUZGNjgzNzBBAAoJECTs/1r/aDcKCxAP/Rby4F1h1heQySr68Q3/kbx+\r
+PZ2hmeZIif5a/mCOG3ZVwM5GFfQEQ5IqhgHsCbirpiGxHTSSJ/k2p8on3d17e9Pw\r
+SUiKVaI0Ii1YoFKkCuDLvaC/LobYApYJitE2YywDKxF8/m7JSXld5lyYlQrjVp84\r
+n7qIWpmk+n80KPDJXxhUS9mk9pXZwiERrhak2c1o9HlqFPWfKeQXRuQcwWNiGLeU\r
+2eEPxDFHhfQoq6kZ1mGrwnqbnbU6il7z1ejsFb02F3UthmQ33WQdsA0ZjMTFWsUu\r
+jOZhpjYzjyudzFz/9azJaVHM7rF8VVbp762fF6iQqiBWZ7aR6guJMJxb31HwTy+d\r
+4Eaa2RFY/BMnQMcfq5XAW2ryxqP4SB4EnVmi8SPoHBO2DYsPw0P5sNBkYhiJVNoA\r
+x+IZBBV2FlyP5DhKAs/VQIb8TMovL9prCJGYdzBoU2LRhAliL7iPggb2KcxXi6Ot\r
+038Ny94fnBoR+khbadDCXlX2Pgx1RFJZxSDMd67knpRhTaae5CMXLtE6sMiXoLQj\r
+YQZi5hWrrI2zJeuLVPjxkKqKRrZ2YpsgHDa5gBs+naecWu7ILKAR185HkqVDA3Y6\r
+XEtYL/5zyWFY4qxeTMhO146LE0BgLSDF0X6lVtB0Y66GFo0KUoa9A7kAyDjbV6nN\r
+V3E0CMJVwftk1z5HZpGx\r
+=XXOg\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r