Re: [PATCH 2/8] lib: private string map (associative array) API

diff --git a/21/c51a3b05c33cf093eb2e1588839749fd12d77a b/21/c51a3b05c33cf093eb2e1588839749fd12d77a
new file mode 100644 (file)
index 0000000..9db5293
--- /dev/null
+++ b/21/c51a3b05c33cf093eb2e1588839749fd12d77a
@@ -0,0 +1,85 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 2B5B86DE0159\r
+ for <notmuch@notmuchmail.org>; Mon, 13 Jun 2016 06:03:05 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.011\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.011 tagged_above=-999 required=5\r
+ tests=[AWL=-0.000, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id UndLpeHuNAiA for <notmuch@notmuchmail.org>;\r
+ Mon, 13 Jun 2016 06:02:56 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 498436DE0127\r
+ for <notmuch@notmuchmail.org>; Mon, 13 Jun 2016 06:02:56 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1bCRVi-0004Lc-4h; Mon, 13 Jun 2016 09:02:34 -0400\r
+Received: (nullmailer pid 24715 invoked by uid 1000);\r
+ Mon, 13 Jun 2016 13:02:45 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/8] lib: private string map (associative array) API\r
+In-Reply-To: <m2oa755x11.fsf@guru.guru-group.fi>\r
+References: <1465779955-5539-1-git-send-email-david@tethera.net>\r
+ <1465779955-5539-3-git-send-email-david@tethera.net>\r
+ <m2oa755x11.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.22+28~gb9bf3f4 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 13 Jun 2016 10:02:45 -0300\r
+Message-ID: <871t41utqi.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 13 Jun 2016 13:03:05 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> On Mon, Jun 13 2016, David Bremner <david@tethera.net> wrote:\r
+>\r
+>> The choice of array implementation is deliberate, for future iterator support\r
+>> ---\r
+>>  lib/Makefile.local    |   1 +\r
+>>  lib/notmuch-private.h |  11 ++++\r
+>>  lib/string-map.c      | 153 ++++++++++++++++++++++++++++++++++++++++++++++++++\r
+>>  3 files changed, 165 insertions(+)\r
+>>  create mode 100644 lib/string-map.c\r
+>>\r
+>> diff --git a/lib/Makefile.local b/lib/Makefile.local\r
+>> index beb9635..9280880 100644\r
+>> --- a/lib/Makefile.local\r
+>> +++ b/lib/Makefile.local\r
+>> @@ -40,6 +40,7 @@ libnotmuch_c_srcs =               \\r
+>>     $(dir)/messages.c       \\r
+>>     $(dir)/sha1.c           \\r
+>>     $(dir)/built-with.c     \\r
+>> +   $(dir)/string-map.c    \\r
+>>     $(dir)/tags.c\r
+>\r
+> I suggest everyone to install editor which supports showing tabs & spaces\r
+> e.g. in different color and also visualizes trailing whitespace & trailing\r
+> empty lines...\r
+>\r
+\r
+Heh. If only such a thing existed. What about a pre-commit hook?\r
+The default (that I have) uses git diff --index --check --cached, but\r
+that seems not to be enough.\r
+\r
+d\r