Re: [PATCH 1/4] Make configure use /bin/bash instead of /bin/sh

diff --git a/30/25bd4b41b70af53c58a4e749500d397db051b8 b/30/25bd4b41b70af53c58a4e749500d397db051b8
new file mode 100644 (file)
index 0000000..0810b1a
--- /dev/null
+++ b/30/25bd4b41b70af53c58a4e749500d397db051b8
@@ -0,0 +1,148 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6AE89431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Apr 2012 11:47:38 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ObFShJJbQywQ for <notmuch@notmuchmail.org>;\r
+       Wed, 11 Apr 2012 11:47:37 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 31974431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Apr 2012 11:47:37 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id B744F68055; Wed, 11 Apr 2012 21:47:32 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Vladimir Marek <Vladimir.Marek@Oracle.COM>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 1/4] Make configure use /bin/bash instead of /bin/sh\r
+In-Reply-To: <20120411084342.GL10554@pub.czech.sun.com>\r
+References: <1333966665-10469-1-git-send-email-Vladimir.Marek@oracle.com>\r
+       <1333966665-10469-2-git-send-email-Vladimir.Marek@oracle.com>\r
+       <CAB+hUn9eVVBN7xzMSUT6kB2+MNn8H6KoKuxGDOwck0sgp9qgmw@mail.gmail.com>\r
+       <20120409121930.GA10554@pub.czech.sun.com>\r
+       <m2ehrv4hx2.fsf@guru.guru-group.fi>\r
+       <20120411084342.GL10554@pub.czech.sun.com>User-Agent:\r
+       Notmuch/0.12+77~gee11800 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 11 Apr 2012 21:47:32 +0300\r
+Message-ID: <m2wr5mm7gb.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 11 Apr 2012 18:47:38 -0000\r
+\r
+On Wed, Apr 11 2012, Vladimir Marek <Vladimir.Marek@Oracle.COM> wrote:\r
+\r
+> Hi,\r
+>\r
+\r
+[ ... ]\r
+\r
+>\r
+>> Does the configure script work if you replace /bin/sh with /bin/ksh\r
+>> in your Solaris box\r
+>\r
+> yes, it does work if executed by /bin/bash or /bin/ksh\r
+>\r
+>\r
+>> If yes, something like the following could be added to the beginning\r
+>> of 'configure'\r
+>> \r
+>> option=option=value\r
+>> if test ! x"${option$*=}" = x"value" 2>/dev/null; then\r
+>>     if test x"${PREVENT_LOOPING-}" = x; then\r
+>>             PREVENT_LOOPING=true; export PREVENT_LOOPING\r
+>>                 test ! -x /bin/ksh || exec /bin/ksh "$0" "$@"\r
+>>                 test ! -x /bin/bash || exec /bin/bash "$0" "$@"\r
+>>         fi\r
+>>         echo "Cannot find compatible shell for '$0'" >&2\r
+>>         exit 1\r
+>> fi\r
+>\r
+> Unfortunately, no. The /bin/sh says "bad substitution" and does not run\r
+> the script at all. I also tried\r
+>\r
+> eval 'echo ${A%%1}'; echo ok\r
+>\r
+> but that does not run the 'echo ok' and fails also.\r
+\r
+You're right! I tested this stuff using heirloom-sh\r
+from http://heirloom.sourceforge.net/sh.html\r
+\r
+It is interesting that the shell stops executing when \r
+it finds this syntax (instead of contnuing, even without -e)\r
+\r
+> I can see three possible solutions\r
+>\r
+> 1) use bash or ksh in the shebang line\r
+\r
+Cannot do there are systems lacking /bin/bash & /bin/ksh\r
+\r
+> 2) rewrite the script as I gave the overview\r
+\r
+Some work todo; case construct can do option key matching to get \r
+identical interface and then cut or sed to get just option value.\r
+\r
+> 3) declare that solaris 10 /bin/sh is not compatible with configure\r
+> script\r
+>\r
+> Frankly even 3) is viable option, one just have to remember to run\r
+> 'bash configure'. If everything else would work, I would be happy :)\r
+\r
+Option 4) use the following heuristics:\r
+\r
+case ~ in '~')\r
+       if test x"${PREVENT_LOOPING-}" = x; then\r
+               PREVENT_LOOPING=true; export PREVENT_LOOPING\r
+               for x in /bin/ksh /bin/bash /usr/bin/bash\r
+               do test ! -x "$x" || exec "$x" "$0" "$@"\r
+                done\r
+       fi\r
+       echo "Cannot find compatible shell for '$0'" >&2\r
+       exit 1\r
+esac\r
+\r
+i.e. if tilde expansion is not done guess this shell is not \r
+compatible enough\r
+\r
+Option 5) do substitution check in subshell:\r
+\r
+( option=option=value; : ${option$*=} ) 2>/dev/null || {\r
+       if test x"${PREVENT_LOOPING-}" = x; then\r
+               PREVENT_LOOPING=true; export PREVENT_LOOPING\r
+               for x in /bin/ksh /bin/bash /usr/bin/bash\r
+               do test ! -x "$x" || exec "$x" "$0" "$@"\r
+                done\r
+       fi\r
+       echo "Cannot find compatible shell for '$0'" >&2\r
+       exit 1\r
+}\r
+\r
+>\r
+> Thank you\r
+> -- \r
+>      Vlad\r
+\r
+Tomi\r