Re: [PATCH v2] test: add "set -u" to test-lib.sh

diff --git a/ab/efd66e5db0562800188a403664141bd5bcc2ae b/ab/efd66e5db0562800188a403664141bd5bcc2ae
new file mode 100644 (file)
index 0000000..5c75218
--- /dev/null
+++ b/ab/efd66e5db0562800188a403664141bd5bcc2ae
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id BEE466DE0261\r
+ for <notmuch@notmuchmail.org>; Mon, 27 Jun 2016 06:49:42 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.011\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.011 tagged_above=-999 required=5 tests=[AWL=0.000,\r
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id RBWNTlPlas7U for <notmuch@notmuchmail.org>;\r
+ Mon, 27 Jun 2016 06:49:35 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id CF7876DE0243\r
+ for <notmuch@notmuchmail.org>; Mon, 27 Jun 2016 06:49:34 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1bHWuY-0001YS-Sd; Mon, 27 Jun 2016 09:49:14 -0400\r
+Received: (nullmailer pid 24225 invoked by uid 1000);\r
+ Mon, 27 Jun 2016 13:49:27 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Cc: tomi.ollila@iki.fi\r
+Subject: Re: [PATCH v2] test: add "set -u" to test-lib.sh\r
+In-Reply-To: <1465336777-31225-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1465336777-31225-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.22+51~gcc1a6d2 (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 27 Jun 2016 15:49:27 +0200\r
+Message-ID: <87a8i64u8o.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 27 Jun 2016 13:49:42 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> This prohibits unset variables to expand to empty strings.\r
+> Without this e.g misspelled variables cause unintentional results.\r
+>\r
+> Now all the test variables are either initialized, or in case of\r
+> optional arguments and user-provided environment variables (i.e.\r
+> when it is not know whethet the variable is set) the form\r
+> ${variable-} is used.\r
+>\r
+> Two unusable lines (leftovers?) in T360-symbol-hiding.sh were removed;\r
+> this was the only non-lib test code that needed to be edited for this\r
+> change to work.\r
+\r
+Hi Tomi;\r
+\r
+I like the idea, but currently I get many test failures with\r
+\r
+/test-lib.sh: line 926: test_subtest_missing_external_prereq_: unbound variable\r
+\r
+d\r