Re: [PATCH 2/4] dirent->d_type not available on Soalris

diff --git a/dc/e3addfa108ccfd4c9a08723352bd23a169e49a b/dc/e3addfa108ccfd4c9a08723352bd23a169e49a
new file mode 100644 (file)
index 0000000..b762390
--- /dev/null
+++ b/dc/e3addfa108ccfd4c9a08723352bd23a169e49a
@@ -0,0 +1,90 @@
+Return-Path: <awg@xvx.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9C4B0417330\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Apr 2012 08:46:52 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Y7btr283TDyw for <notmuch@notmuchmail.org>;\r
+       Mon,  9 Apr 2012 08:46:51 -0700 (PDT)\r
+Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com\r
+       [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 8D694417322\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Apr 2012 08:46:51 -0700 (PDT)\r
+Received: by lban1 with SMTP id n1so2151991lba.26\r
+       for <notmuch@notmuchmail.org>; Mon, 09 Apr 2012 08:46:48 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=mime-version:sender:x-originating-ip:in-reply-to:references:date\r
+       :x-google-sender-auth:message-id:subject:from:to:content-type\r
+       :x-gm-message-state;\r
+       bh=jYf3WZ/KdVSarJ/GD3eUBvak5Rg8ru1l64judCndEGw=;\r
+       b=k1bxYdBK6glTKsC2UFOVYCK/1XdNQv/VoOHX/YX3wk3He3ZU6AiuqwywyWnD8SXmXJ\r
+       16VFrUUBLbjZQXQgNbIrzU567AtXeLwlCRjFt8x67dofuRtJEyuOIyFVQzxyZ6BKh+dp\r
+       AIzDXF8oVm7DbVkK+io5L+Q8JVKfq3dw9+FFe3siqunsHpXThzSpWjNzUGM8COjmKXKk\r
+       lGFSNx9Gg2aCdZ6yUQtTY4YVhSsXPebDERdFR1rCi0OXNs1IS9fWlc4eUHqMrHZH0c4Z\r
+       KtkMuAhoXYS7D5PSFLjGcWgBqqEKg2VamC8xBlK0wvWETy3YDw6dyyHgopbQvMe04DSO\r
+       JHrg==\r
+MIME-Version: 1.0\r
+Received: by 10.152.112.161 with SMTP id ir1mr12148984lab.13.1333986408438;\r
+       Mon, 09 Apr 2012 08:46:48 -0700 (PDT)\r
+Sender: awg@xvx.ca\r
+Received: by 10.112.97.14 with HTTP; Mon, 9 Apr 2012 08:46:48 -0700 (PDT)\r
+X-Originating-IP: [128.221.197.57]\r
+In-Reply-To: <20120409151258.GB10554@pub.czech.sun.com>\r
+References: <1333966665-10469-1-git-send-email-Vladimir.Marek@oracle.com>\r
+       <1333966665-10469-3-git-send-email-Vladimir.Marek@oracle.com>\r
+       <CAB+hUn_gFp+bspNFa-4e6hnH077Sx3to8jZGo1MSwt82QFwxwQ@mail.gmail.com>\r
+       <20120409151258.GB10554@pub.czech.sun.com>\r
+Date: Mon, 9 Apr 2012 09:46:48 -0600\r
+X-Google-Sender-Auth: cFbPKTGG27IfhA76xuicJyn5pAM\r
+Message-ID:\r
+ <CAMoJFUvHbSfXLTGKf2ZZnaLpLzZiHJ7W_ZUYZzm70n5mw4r1Kg@mail.gmail.com>\r
+Subject: Re: [PATCH 2/4] dirent->d_type not available on Soalris\r
+From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>\r
+To: Notmuch Mail <notmuch@notmuchmail.org>\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+X-Gm-Message-State:\r
+ ALoCoQl3E8S3h8NubFEqV4NB1FMNrSgPlHhn+1rd1bMtqacAPI4HSmDzPjhlzvNfhXdFrFfdq/b/\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 09 Apr 2012 15:46:52 -0000\r
+\r
+On Mon, Apr 9, 2012 at 09:12, Vladimir Marek <Vladimir.Marek@oracle.com> wrote:\r
+> Fair enough. Is there some performance test suite? Another way would be\r
+> to make this compile time option set by configure. Used only when the\r
+> system in question does not have dirent->d_type member.\r
+\r
+I like the idea of making it configurable. From the Linux readdir(3) man page:\r
+\r
+> Under glibc, programs can check  for  the  availability\r
+> of  the  fields  not defined in POSIX.1 by testing whether\r
+> the macros _DIRENT_HAVE_D_NAMLEN,\r
+> _DIRENT_HAVE_D_RECLEN, _DIRENT_HAVE_D_OFF,\r
+> or  _DIRENT_HAVE_D_TYPE  are defined.\r
+\r
+I read this as meaning that we can just test for _DIRENT_HAVE_D_TYPE\r
+instead of adding our own define.\r
+\r
+I expect the stat system calls will provide some overhead, and there's\r
+no real need to pay that overhead on systems where it isn't necessary.\r
+\r
+-- Adam\r